You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by onurkaraman <gi...@git.apache.org> on 2016/05/05 05:32:24 UTC

[GitHub] kafka pull request: KAFKA-3494: add metric id to client mbeans

GitHub user onurkaraman opened a pull request:

    https://github.com/apache/kafka/pull/1323

    KAFKA-3494: add metric id to client mbeans

    KafkaConsumer and KafkaProducer mbeans currently only have a client-id granularity. Client-id represents a logical name for an application.
    
    Given that quotas encourage reuse of client-ids, it's not unexpected to have multiple clients share the same client-id within the same jvm. When a later client gets instantiated with the same client-id as an earlier client in the same jvm, JmxReporter unregisters the original client's mbeans that collide with the new client's mbeans.
    
    This commit makes client mbeans have a metric-id granularity to prevent mbean collision and the original client mbean unregistration.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/onurkaraman/kafka KAFKA-3494

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1323.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1323
    
----
commit 40a0189e856ba42be396bd2694e5719e8e29631b
Author: Onur Karaman <ok...@linkedin.com>
Date:   2016-05-04T23:34:28Z

    add metric id to client mbeans
    
    KafkaConsumer and KafkaProducer mbeans currently only have a client-id granularity. Client-id represents a logical name for an application.
    
    Given that quotas encourage reuse of client-ids, it's not unexpected to have multiple clients share the same client-id within the same jvm. When a later client gets instantiated with the same client-id as an earlier client in the same jvm, JmxReporter unregisters the original client's mbeans that collide with the new client's mbeans.
    
    This commit makes client mbeans have a metric-id granularity to prevent mbean collision and the original client mbean unregistration.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---