You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/10/30 23:57:47 UTC
Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
Bugs: MESOS-8050
https://issues.apache.org/jira/browse/MESOS-8050
Repository: mesos
Description
-------
Added IPv6 capabilities for TCP and HTTP healthchecks.
Diffs
-----
include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
Diff: https://reviews.apache.org/r/63434/diff/1/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review190004
-----------------------------------------------------------
PASS: Mesos patch 63434 was successfully built and tested.
Reviews applied: `['63434']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63434
- Mesos Reviewbot Windows
On Nov. 3, 2017, 12:38 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 12:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 7, 2017, 2:22 p.m., Qian Zhang wrote:
> > I think you need to do the similar changes to the `CheckInfo` message.
>
> Avinash sridharan wrote:
> `CheckInfo` is specific to the `default-executor` and hence UCR. We don't support IPv6 for CNI and hence UCR at this point, so hence not adding this to `CheckInfo` at this point.
Yeah, I'm not quite sure how the whole IPv6 story will look like, hence let's not touch `CheckInfo` for now.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review190303
-----------------------------------------------------------
On Nov. 3, 2017, 12:38 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 12:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On Nov. 7, 2017, 2:22 p.m., Qian Zhang wrote:
> > I think you need to do the similar changes to the `CheckInfo` message.
`CheckInfo` is specific to the `default-executor` and hence UCR. We don't support IPv6 for CNI and hence UCR at this point, so hence not adding this to `CheckInfo` at this point.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review190303
-----------------------------------------------------------
On Nov. 3, 2017, 12:38 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 12:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review190303
-----------------------------------------------------------
I think you need to do the similar changes to the `CheckInfo` message.
- Qian Zhang
On Nov. 3, 2017, 8:38 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 8:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review190011
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63434]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Nov. 2, 2017, 5:38 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2017, 5:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review190437
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 3, 2017, 12:38 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 12:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/
-----------------------------------------------------------
(Updated Nov. 3, 2017, 12:38 a.m.)
Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
Changes
-------
Addressed Vinod's and AlexR's comments.
Bugs: MESOS-8050
https://issues.apache.org/jira/browse/MESOS-8050
Repository: mesos
Description
-------
Added IPv6 capabilities for TCP and HTTP healthchecks.
Diffs (updated)
-----
include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
Diff: https://reviews.apache.org/r/63434/diff/2/
Changes: https://reviews.apache.org/r/63434/diff/1-2/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Vinod Kone <vi...@apache.org>.
> On Nov. 2, 2017, 6:48 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto
> > Lines 512-516 (patched)
> > <https://reviews.apache.org/r/63434/diff/1/?file=1873100#file1873100line512>
> >
> > When I see this enum, I have several questions, for example, "how this fits into overall IPv6 story?", "shall this enum be global?", "what about `CheckInfo` message?". Since we are going to deprecate `HealchCheck` at some point, I'm fine with adding an ad-hoc solution here, but I would like to have a note here about what our long-term plan is (and that provides some sorts of answers to the questions above).
Yea, one option is to directly use "NetworkInfo::Protocol" instead of re-declaring it here.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review189946
-----------------------------------------------------------
On Oct. 30, 2017, 11:57 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 11:57 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On Nov. 2, 2017, 6:48 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto
> > Lines 512-516 (patched)
> > <https://reviews.apache.org/r/63434/diff/1/?file=1873100#file1873100line512>
> >
> > When I see this enum, I have several questions, for example, "how this fits into overall IPv6 story?", "shall this enum be global?", "what about `CheckInfo` message?". Since we are going to deprecate `HealchCheck` at some point, I'm fine with adding an ad-hoc solution here, but I would like to have a note here about what our long-term plan is (and that provides some sorts of answers to the questions above).
>
> Vinod Kone wrote:
> Yea, one option is to directly use "NetworkInfo::Protocol" instead of re-declaring it here.
I like that option, since it will be tied to `NetworkInfo` which will encapsulate our support for IPv4 and IPv6.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review189946
-----------------------------------------------------------
On Nov. 3, 2017, 12:38 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2017, 12:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review189946
-----------------------------------------------------------
include/mesos/mesos.proto
Lines 512-516 (patched)
<https://reviews.apache.org/r/63434/#comment267192>
When I see this enum, I have several questions, for example, "how this fits into overall IPv6 story?", "shall this enum be global?", "what about `CheckInfo` message?". Since we are going to deprecate `HealchCheck` at some point, I'm fine with adding an ad-hoc solution here, but I would like to have a note here about what our long-term plan is (and that provides some sorts of answers to the questions above).
include/mesos/mesos.proto
Lines 523 (patched)
<https://reviews.apache.org/r/63434/#comment267193>
Let's call it `protocol` to avoid confusion
- Alexander Rukletsov
On Oct. 30, 2017, 11:57 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 11:57 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review189693
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63434]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 30, 2017, 11:57 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 11:57 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP
healthchecks.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review189750
-----------------------------------------------------------
PASS: Mesos patch 63434 was successfully built and tested.
Reviews applied: `['63434']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63434
- Mesos Reviewbot Windows
On Oct. 30, 2017, 11:57 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 11:57 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added IPv6 capabilities for TCP and HTTP healthchecks.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b
> include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b
>
>
> Diff: https://reviews.apache.org/r/63434/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>