[GitHub] sijie commented on a change in pull request #1552: Provide utils to dump component configuration as json string

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1552: Provide utils to dump component configuration as json string
URL: https://github.com/apache/bookkeeper/pull/1552#discussion_r203122610
 
 

 ##########
 File path: bookkeeper-common/src/main/java/org/apache/bookkeeper/common/conf/ComponentConfiguration.java
 ##########
 @@ -287,4 +291,31 @@ public String getString(String key, String defaultValue) {
     public List<Object> getList(String key, List<?> defaultValue) {
         return conf.getList(getKeyName(key), defaultValue);
     }
+
+    /**
+     * returns the string representation of json format of this config.
+     *
+     * @return
+     * @throws ParseJsonException
+     */
+    public String asJson() {
 
 Review comment:
   it is used in a subsequent pull request: https://github.com/apache/bookkeeper/pull/1553/files#diff-3f4d443c559ae8b071b0229fbb91df2aR209
   
   I am breaking the changes into small changes, so they are easier to be reviewed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services