Re: Deprecating the bundleall goal

[Johannes Schneider <ma...@cedarsoft.com>]

Hi Stuart,


we are using that goal here. It seems to work well for a lot of
libraries. And not so well for some others...

While I agree that the current goal has several faults, I think that the
idea behind the goal is nice. Many, many libraries don't have a valid
MANIFEST. And I would love a simple and easy way to wrap them up.

Does there exist an alternative to "bundleall"?


Thanks,

Johannes

On 16.06.2011 20:22, Stuart McCulloch wrote:
> Hi folks,
> 
> I'm planning to deprecate the "bundleall" goal since it has several faults,
> produces low quality bundles, and was never meant to be used by everyday
> projects.
> 
> Any objections?  The goal will still be available in the next minor release,
> but marked as deprecated with a warning - the next major release would
> remove it.
> 
> --
> Cheers, Stuart
> 
> Begin forwarded message:
> 
> *From: *mcculls@apache.org
> *Date: *16 June 2011 18:41:19 GMT+01:00
> *To: *commits@felix.apache.org
> *Subject: **svn commit: r1136563 -
> /felix/trunk/bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundleAllPlugin.java
> *
> *Reply-To: *dev@felix.apache.org
> 
> Author: mcculls
> Date: Thu Jun 16 17:41:18 2011
> New Revision: 1136563
> 
> URL: http://svn.apache.org/viewvc?rev=1136563&view=rev
> Log:
> Deprecate the bundleall goal
> 
> Modified:
>    felix/trunk/bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundleAllPlugin.java
> 
> Modified:
> felix/trunk/bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundleAllPlugin.java
> URL:
> http://svn.apache.org/viewvc/felix/trunk/bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundleAllPlugin.java?rev=1136563&r1=1136562&r2=1136563&view=diff
> ==============================================================================
> ---
> felix/trunk/bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundleAllPlugin.java
> (original)
> +++
> felix/trunk/bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundleAllPlugin.java
> Thu Jun 16 17:41:18 2011
> @@ -64,7 +64,9 @@ import aQute.lib.osgi.Jar;
>  * @phase package
>  * @requiresDependencyResolution test
>  * @description build an OSGi bundle jar for all transitive dependencies
> + * @deprecated The bundleall goal is no longer supported and may be removed
> in a future release
>  */
> +@Deprecated
> public class BundleAllPlugin extends ManifestPlugin
> {
>     private static final String LS = System.getProperty( "line.separator" );
> @@ -174,6 +176,9 @@ public class BundleAllPlugin extends Man
>      */
>     protected BundleInfo bundleAll( MavenProject project, int maxDepth )
> throws MojoExecutionException
>     {
> +        getLog().warn(
> "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
> );
> +        getLog().warn( "! The bundleall goal is no longer supported and may
> be removed in a future release !" );
> +        getLog().warn(
> "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
> );
> 
>         if ( alreadyBundled( project.getArtifact() ) )
>         {
> 
> 
> 
> 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@felix.apache.org
For additional commands, e-mail: users-help@felix.apache.org