[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1796: IGNITE-19014 Topology aware Raft client creates its own message handler which is not aware of Raft group

["vldpyatkov (via GitHub)" <gi...@apache.org>]

vldpyatkov commented on code in PR #1796:
URL: https://github.com/apache/ignite-3/pull/1796#discussion_r1138309573


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -173,6 +165,14 @@ public void onWrite(Iterator<CommandClosure<WriteCommand>> iterator) {
                     assert false : "Command was not found [cmd=" + command + ']';
                 }
 
+                if (command instanceof SafeTimePropagatingCommand) {

Review Comment:
   Shouldn't handle safe time in the snapshot lock. At lest until it is not stored in the storage.



##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/raft/client/TopologyAwareRaftGroupService.java:
##########
@@ -72,6 +71,10 @@ public class TopologyAwareRaftGroupService implements RaftGroupService {
     /** Leader election handler. */
     private final ServerEventHandler serverEventHandler;
 
+    private final BiConsumer<ClusterNode, Long> leaderElectionListener;

Review Comment:
   This property is excess.



##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -342,12 +343,15 @@ public class IgniteImpl implements Ignite {
                 )
         );
 
+        RaftGroupEventsClientListener raftGroupEventsClientListener = new RaftGroupEventsClientListener();

Review Comment:
   As we discussed before, TODO here is required, to move the property to a factory for various types of clients.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org