You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/03/10 23:58:48 UTC
Review Request 44681: AMBARI-15378 Create multiple version state
filters instead of one combined one on host page for version page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44681/
-----------------------------------------------------------
Review request for Ambari, Andrii Tkach, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15378
https://issues.apache.org/jira/browse/AMBARI-15378
Repository: ambari
Description
-------
On version detail of versions page, if click the number of Not Installed hosts, it will try to create filter "Version State: Installing, Installing, Out of Sync", which is not a supported format of combo search box.
It should create 3 individual filters.
Diffs
-----
ambari-web/app/controllers/main/host.js efc0ba2
Diff: https://reviews.apache.org/r/44681/diff/
Testing
-------
Local ambari-web test passed.
24562 tests complete (21 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 44681: AMBARI-15378 Create multiple version state
filters instead of one combined one on host page for version page
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44681/#review123024
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On March 10, 2016, 10:58 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44681/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 10:58 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15378
> https://issues.apache.org/jira/browse/AMBARI-15378
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On version detail of versions page, if click the number of Not Installed hosts, it will try to create filter "Version State: Installing, Installing, Out of Sync", which is not a supported format of combo search box.
> It should create 3 individual filters.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host.js efc0ba2
>
> Diff: https://reviews.apache.org/r/44681/diff/
>
>
> Testing
> -------
>
> Local ambari-web test passed.
> 24562 tests complete (21 seconds)
> 145 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>