You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "pvillard31 (via GitHub)" <gi...@apache.org> on 2026/09/03 10:43:18 UTC

[PR] NIFI-16286 - Prevent stale Parameter Context provenance from breaking context retrieval [nifi]

pvillard31 opened a new pull request, #11618:
URL: https://github.com/apache/nifi/pull/11618

   # Summary
   
   NIFI-16286 - Prevent stale Parameter Context provenance from breaking context retrieval
   
   Parameter Context update requests can round-trip effective Parameter DTOs containing source-context metadata and incorrectly persist that client-supplied context ID on a locally accepted Parameter. If the referenced source context is later deleted, the stale provenance can cause Parameter Context listing, detail retrieval, or effective-update analysis to fail with `ResourceNotFoundException`. Normalize locally accepted Parameters so ownership is determined by the target context, preserve valid inherited provenance, and make DTO rendering and update analysis tolerate missing or concurrently removed source contexts with value-safe warning diagnostics. Add unit, standalone, and clustered regression coverage for local, provided, asset-backed, inherited, missing-source, and concurrent-removal scenarios.
   
   Explanations for the changes:
   
   - `StandardParameterContextDAO`
   
   Normalize the provenance of Parameters accepted as local definitions instead of copying `ParameterDTO.parameterContext.id` from the request. This prevents response metadata round-tripped by a client from creating a local Parameter that incorrectly references another, potentially deleted, Parameter Context, while preserving values, sensitivity, descriptions, provider status, and asset references.
   
   - `DtoFactory`
   
   Resolve a Parameter’s source through the inheritance graph first, then consult the global lookup only when the source is known to exist. If the source is missing or disappears during lookup, report the Parameter as locally defined and emit a value-safe warning instead of allowing `ResourceNotFoundException` to break Parameter Context listing or detail retrieval.
   
   - `StandardNiFiServiceFacade`
   
   Apply the same missing-source containment while calculating effective Parameter updates and affected components. Valid inherited provenance remains unchanged, but an unresolved or concurrently removed source now falls back to the current context with a diagnostic warning rather than failing the update-analysis request.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - Pull Request based on current revision of the `main` branch
   - Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-16286 - Prevent stale Parameter Context provenance from breaking context retrieval [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #11618:
URL: https://github.com/apache/nifi/pull/11618


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-16286 - Prevent stale Parameter Context provenance from breaking context retrieval [nifi]

Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #11618:
URL: https://github.com/apache/nifi/pull/11618#issuecomment-5554533788

   Thanks for the review @exceptionfactory - pushed a commit to address your feedback


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org