You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/02 08:18:43 UTC

[GitHub] [spark] JkSelf commented on a change in pull request #32705: [SPARK-35568][SQL] Avoid UnsupportedOperationException when enabling both AQE and DPP

JkSelf commented on a change in pull request #32705:
URL: https://github.com/apache/spark/pull/32705#discussion_r643758074



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -312,7 +312,15 @@ case class AdaptiveSparkPlanExec(
   }
 
   override def doExecuteBroadcast[T](): broadcast.Broadcast[T] = {
-    getFinalPhysicalPlan().doExecuteBroadcast()
+    getFinalPhysicalPlan() match {

Review comment:
       The root cause of this bug may be the loss of `BroadcastExchange` node in DPP filter. I commit a initial idea in [PR#32741](https://github.com/apache/spark/pull/32741).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org