You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "deven you (JIRA)" <ji...@apache.org> on 2010/03/03 09:09:27 UTC
[jira] Created: (HARMONY-6460) [classlib][fdlibm]Upgrade fdlibm5.2
to 5.3
[classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
------------------------------------------
Key: HARMONY-6460
URL: https://issues.apache.org/jira/browse/HARMONY-6460
Project: Harmony
Issue Type: Improvement
Components: Classlib
Affects Versions: 5.0M14
Reporter: deven you
Fix For: 5.0M14
Hi All,
I noticed that java spec says "The Java math library is defined with respect to fdlibm version 5.3." within java.lang.StrictMath class specification from jdk 5.0. However our harmony still use fdlibm5.2. And a test case[1] shows harmony's math functions results are different compared to ri 6.0 for this reason.
So I think we should upgrade fdlibm from 5.2 to 5.3 to keep consistency with ri. I have done this on my local machine by following steps:
1. Download fdlibm5.3 zip file from http://www.validlab.com/software/
2. Unzip the zip file, this will unzip a folder named fdlibm53 on current path. Then enter fdlibm53 and rename fdlibm.h, Makefile, Makefile.in and s_lib_version.c with suffix .orig.
3. Re package all files in fdlibm53 into fdlibm_5.3.zip.
4. Replace HYROOT/deploy/oss/fdlibm_5.2.zip with the above fdlibm_5.3.zip, HYROOT is the root directory of harmony classlib trunk repository.
5. Apply attached patch[2].
6. Build the trunk and run corresponding test case.
[1][2]: see the attached files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6460) [classlib][fdlibm]Upgrade
fdlibm5.2 to 5.3
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843508#action_12843508 ]
Hudson commented on HARMONY-6460:
---------------------------------
Integrated in Harmony-1.5-head-linux-x86_64 #654 (See [http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/654/])
Apply patch for : [classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
> [classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
> ------------------------------------------
>
> Key: HARMONY-6460
> URL: https://issues.apache.org/jira/browse/HARMONY-6460
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M14
> Reporter: deven you
> Assignee: Regis Xu
> Fix For: 5.0M14
>
> Attachments: HARMONY-6460.diff, HARMONY-6460.v2.diff, HY-6460.diff, TestMathTan.java
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Hi All,
> I noticed that java spec says "The Java math library is defined with respect to fdlibm version 5.3." within java.lang.StrictMath class specification from jdk 5.0. However our harmony still use fdlibm5.2. And a test case[1] shows harmony's math functions results are different compared to ri 6.0 for this reason.
> So I think we should upgrade fdlibm from 5.2 to 5.3 to keep consistency with ri. I have done this on my local machine by following steps:
> 1. Download fdlibm5.3 zip file from http://www.validlab.com/software/
> 2. Unzip the zip file, this will unzip a folder named fdlibm53 on current path. Then enter fdlibm53 and rename fdlibm.h, Makefile, Makefile.in and s_lib_version.c with suffix .orig.
> 3. Re package all files in fdlibm53 into fdlibm_5.3.zip.
> 4. Replace HYROOT/deploy/oss/fdlibm_5.2.zip with the above fdlibm_5.3.zip, HYROOT is the root directory of harmony classlib trunk repository.
> 5. Apply attached patch[2].
> 6. Build the trunk and run corresponding test case.
> [1][2]: see the attached files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6460) [classlib][fdlibm]Upgrade fdlibm5.2
to 5.3
Posted by "deven you (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
deven you updated HARMONY-6460:
-------------------------------
Attachment: TestMathTan.java
Test case for Math.tan() and StrictMath.tan()
the result are below:
on ri6: sun's 1.6.0_14
Math.tan(3.243923053425431E274) is 5.4039182542783925E14
StrictMath.tan(3.243923053425431E274) is 5.4039182542783925E14
Math.tan(2.0035964250000004E7) is -3.117343612134583E10
StrictMath.tan(2.0035964250000004E7) is -3.117343612134583E10
on harmony trunk
Math.tan(3.243923053425431E274) is 5.403918254278393E14
StrictMath.tan(3.243923053425431E274) is 5.403918254278393E14
Math.tan(2.0035964250000004E7) is -3.1173436121345825E10
StrictMath.tan(2.0035964250000004E7) is -3.1173436121345825E10
> [classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
> ------------------------------------------
>
> Key: HARMONY-6460
> URL: https://issues.apache.org/jira/browse/HARMONY-6460
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M14
> Reporter: deven you
> Fix For: 5.0M14
>
> Attachments: TestMathTan.java
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Hi All,
> I noticed that java spec says "The Java math library is defined with respect to fdlibm version 5.3." within java.lang.StrictMath class specification from jdk 5.0. However our harmony still use fdlibm5.2. And a test case[1] shows harmony's math functions results are different compared to ri 6.0 for this reason.
> So I think we should upgrade fdlibm from 5.2 to 5.3 to keep consistency with ri. I have done this on my local machine by following steps:
> 1. Download fdlibm5.3 zip file from http://www.validlab.com/software/
> 2. Unzip the zip file, this will unzip a folder named fdlibm53 on current path. Then enter fdlibm53 and rename fdlibm.h, Makefile, Makefile.in and s_lib_version.c with suffix .orig.
> 3. Re package all files in fdlibm53 into fdlibm_5.3.zip.
> 4. Replace HYROOT/deploy/oss/fdlibm_5.2.zip with the above fdlibm_5.3.zip, HYROOT is the root directory of harmony classlib trunk repository.
> 5. Apply attached patch[2].
> 6. Build the trunk and run corresponding test case.
> [1][2]: see the attached files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6460) [classlib][fdlibm]Upgrade fdlibm5.2
to 5.3
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu resolved HARMONY-6460.
-------------------------------
Resolution: Fixed
Patch HARMONY-6460.v2.diff was applied at r921268.
Deven, please verify if that works for you, thanks.
> [classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
> ------------------------------------------
>
> Key: HARMONY-6460
> URL: https://issues.apache.org/jira/browse/HARMONY-6460
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M14
> Reporter: deven you
> Assignee: Regis Xu
> Fix For: 5.0M14
>
> Attachments: HARMONY-6460.diff, HARMONY-6460.v2.diff, HY-6460.diff, TestMathTan.java
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Hi All,
> I noticed that java spec says "The Java math library is defined with respect to fdlibm version 5.3." within java.lang.StrictMath class specification from jdk 5.0. However our harmony still use fdlibm5.2. And a test case[1] shows harmony's math functions results are different compared to ri 6.0 for this reason.
> So I think we should upgrade fdlibm from 5.2 to 5.3 to keep consistency with ri. I have done this on my local machine by following steps:
> 1. Download fdlibm5.3 zip file from http://www.validlab.com/software/
> 2. Unzip the zip file, this will unzip a folder named fdlibm53 on current path. Then enter fdlibm53 and rename fdlibm.h, Makefile, Makefile.in and s_lib_version.c with suffix .orig.
> 3. Re package all files in fdlibm53 into fdlibm_5.3.zip.
> 4. Replace HYROOT/deploy/oss/fdlibm_5.2.zip with the above fdlibm_5.3.zip, HYROOT is the root directory of harmony classlib trunk repository.
> 5. Apply attached patch[2].
> 6. Build the trunk and run corresponding test case.
> [1][2]: see the attached files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6460) [classlib][fdlibm]Upgrade fdlibm5.2
to 5.3
Posted by "deven you (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
deven you closed HARMONY-6460.
------------------------------
it has been fixed
> [classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
> ------------------------------------------
>
> Key: HARMONY-6460
> URL: https://issues.apache.org/jira/browse/HARMONY-6460
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M14
> Reporter: deven you
> Assignee: Regis Xu
> Fix For: 5.0M14
>
> Attachments: HARMONY-6460.diff, HARMONY-6460.v2.diff, HY-6460.diff, TestMathTan.java
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Hi All,
> I noticed that java spec says "The Java math library is defined with respect to fdlibm version 5.3." within java.lang.StrictMath class specification from jdk 5.0. However our harmony still use fdlibm5.2. And a test case[1] shows harmony's math functions results are different compared to ri 6.0 for this reason.
> So I think we should upgrade fdlibm from 5.2 to 5.3 to keep consistency with ri. I have done this on my local machine by following steps:
> 1. Download fdlibm5.3 zip file from http://www.validlab.com/software/
> 2. Unzip the zip file, this will unzip a folder named fdlibm53 on current path. Then enter fdlibm53 and rename fdlibm.h, Makefile, Makefile.in and s_lib_version.c with suffix .orig.
> 3. Re package all files in fdlibm53 into fdlibm_5.3.zip.
> 4. Replace HYROOT/deploy/oss/fdlibm_5.2.zip with the above fdlibm_5.3.zip, HYROOT is the root directory of harmony classlib trunk repository.
> 5. Apply attached patch[2].
> 6. Build the trunk and run corresponding test case.
> [1][2]: see the attached files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6460) [classlib][fdlibm]Upgrade fdlibm5.2
to 5.3
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu reassigned HARMONY-6460:
---------------------------------
Assignee: Regis Xu
> [classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
> ------------------------------------------
>
> Key: HARMONY-6460
> URL: https://issues.apache.org/jira/browse/HARMONY-6460
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M14
> Reporter: deven you
> Assignee: Regis Xu
> Fix For: 5.0M14
>
> Attachments: HARMONY-6460.diff, HARMONY-6460.v2.diff, HY-6460.diff, TestMathTan.java
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Hi All,
> I noticed that java spec says "The Java math library is defined with respect to fdlibm version 5.3." within java.lang.StrictMath class specification from jdk 5.0. However our harmony still use fdlibm5.2. And a test case[1] shows harmony's math functions results are different compared to ri 6.0 for this reason.
> So I think we should upgrade fdlibm from 5.2 to 5.3 to keep consistency with ri. I have done this on my local machine by following steps:
> 1. Download fdlibm5.3 zip file from http://www.validlab.com/software/
> 2. Unzip the zip file, this will unzip a folder named fdlibm53 on current path. Then enter fdlibm53 and rename fdlibm.h, Makefile, Makefile.in and s_lib_version.c with suffix .orig.
> 3. Re package all files in fdlibm53 into fdlibm_5.3.zip.
> 4. Replace HYROOT/deploy/oss/fdlibm_5.2.zip with the above fdlibm_5.3.zip, HYROOT is the root directory of harmony classlib trunk repository.
> 5. Apply attached patch[2].
> 6. Build the trunk and run corresponding test case.
> [1][2]: see the attached files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6460) [classlib][fdlibm]Upgrade fdlibm5.2
to 5.3
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu updated HARMONY-6460:
------------------------------
Attachment: HARMONY-6460.v2.diff
New patch HARMONY-6460.v2.diff check fdlibm dependency in luni's build.xml, thanks Mark's advices.
> [classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
> ------------------------------------------
>
> Key: HARMONY-6460
> URL: https://issues.apache.org/jira/browse/HARMONY-6460
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M14
> Reporter: deven you
> Fix For: 5.0M14
>
> Attachments: HARMONY-6460.diff, HARMONY-6460.v2.diff, HY-6460.diff, TestMathTan.java
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Hi All,
> I noticed that java spec says "The Java math library is defined with respect to fdlibm version 5.3." within java.lang.StrictMath class specification from jdk 5.0. However our harmony still use fdlibm5.2. And a test case[1] shows harmony's math functions results are different compared to ri 6.0 for this reason.
> So I think we should upgrade fdlibm from 5.2 to 5.3 to keep consistency with ri. I have done this on my local machine by following steps:
> 1. Download fdlibm5.3 zip file from http://www.validlab.com/software/
> 2. Unzip the zip file, this will unzip a folder named fdlibm53 on current path. Then enter fdlibm53 and rename fdlibm.h, Makefile, Makefile.in and s_lib_version.c with suffix .orig.
> 3. Re package all files in fdlibm53 into fdlibm_5.3.zip.
> 4. Replace HYROOT/deploy/oss/fdlibm_5.2.zip with the above fdlibm_5.3.zip, HYROOT is the root directory of harmony classlib trunk repository.
> 5. Apply attached patch[2].
> 6. Build the trunk and run corresponding test case.
> [1][2]: see the attached files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6460) [classlib][fdlibm]Upgrade fdlibm5.2
to 5.3
Posted by "deven you (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
deven you updated HARMONY-6460:
-------------------------------
Attachment: HY-6460.diff
> [classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
> ------------------------------------------
>
> Key: HARMONY-6460
> URL: https://issues.apache.org/jira/browse/HARMONY-6460
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M14
> Reporter: deven you
> Fix For: 5.0M14
>
> Attachments: HY-6460.diff, TestMathTan.java
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Hi All,
> I noticed that java spec says "The Java math library is defined with respect to fdlibm version 5.3." within java.lang.StrictMath class specification from jdk 5.0. However our harmony still use fdlibm5.2. And a test case[1] shows harmony's math functions results are different compared to ri 6.0 for this reason.
> So I think we should upgrade fdlibm from 5.2 to 5.3 to keep consistency with ri. I have done this on my local machine by following steps:
> 1. Download fdlibm5.3 zip file from http://www.validlab.com/software/
> 2. Unzip the zip file, this will unzip a folder named fdlibm53 on current path. Then enter fdlibm53 and rename fdlibm.h, Makefile, Makefile.in and s_lib_version.c with suffix .orig.
> 3. Re package all files in fdlibm53 into fdlibm_5.3.zip.
> 4. Replace HYROOT/deploy/oss/fdlibm_5.2.zip with the above fdlibm_5.3.zip, HYROOT is the root directory of harmony classlib trunk repository.
> 5. Apply attached patch[2].
> 6. Build the trunk and run corresponding test case.
> [1][2]: see the attached files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6460) [classlib][fdlibm]Upgrade fdlibm5.2
to 5.3
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu updated HARMONY-6460:
------------------------------
Attachment: HARMONY-6460.diff
patch HARMONY-6460.diff use standard {check,fetch}-depends mechanism, and also change LICENSE file
> [classlib][fdlibm]Upgrade fdlibm5.2 to 5.3
> ------------------------------------------
>
> Key: HARMONY-6460
> URL: https://issues.apache.org/jira/browse/HARMONY-6460
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M14
> Reporter: deven you
> Fix For: 5.0M14
>
> Attachments: HARMONY-6460.diff, HY-6460.diff, TestMathTan.java
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Hi All,
> I noticed that java spec says "The Java math library is defined with respect to fdlibm version 5.3." within java.lang.StrictMath class specification from jdk 5.0. However our harmony still use fdlibm5.2. And a test case[1] shows harmony's math functions results are different compared to ri 6.0 for this reason.
> So I think we should upgrade fdlibm from 5.2 to 5.3 to keep consistency with ri. I have done this on my local machine by following steps:
> 1. Download fdlibm5.3 zip file from http://www.validlab.com/software/
> 2. Unzip the zip file, this will unzip a folder named fdlibm53 on current path. Then enter fdlibm53 and rename fdlibm.h, Makefile, Makefile.in and s_lib_version.c with suffix .orig.
> 3. Re package all files in fdlibm53 into fdlibm_5.3.zip.
> 4. Replace HYROOT/deploy/oss/fdlibm_5.2.zip with the above fdlibm_5.3.zip, HYROOT is the root directory of harmony classlib trunk repository.
> 5. Apply attached patch[2].
> 6. Build the trunk and run corresponding test case.
> [1][2]: see the attached files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.