[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42729: [SPARK-45012][SQL] CheckAnalysis should throw inlined plan in AnalysisException

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42729:
URL: https://github.com/apache/spark/pull/42729#discussion_r1309665804


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -209,13 +209,8 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor
     if (plan.analyzed) return plan
     AnalysisHelper.markInAnalyzer {
       val analyzed = executeAndTrack(plan, tracker)
-      try {
-        checkAnalysis(analyzed)
-        analyzed
-      } catch {
-        case e: AnalysisException =>
-          throw new ExtendedAnalysisException(e, analyzed)
-      }

Review Comment:
   The removed code seems to be used very long time. When we remove `try ... catch ...` here, I'm wondering if there is any chance of side effect in the following which currently throws `ExtendedAnalysisException` instead of `AnalysisException`?
   
   https://github.com/apache/spark/blob/742a892d58e4e5fc960a58dc4c7e12e9c41073bd/sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala#L87



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org