You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/17 21:47:22 UTC
[GitHub] [airflow] saurabhdhupar opened a new pull request #7447: [AIRFLOW-6821] - Success callback not called when task marked as succ…
saurabhdhupar opened a new pull request #7447: [AIRFLOW-6821] - Success callback not called when task marked as succ…
URL: https://github.com/apache/airflow/pull/7447
…ess from UI
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ x] Description above provides context of the change
- [ x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x ] Unit tests coverage for changes (not needed for documentation changes)
- [x ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ x] Relevant documentation is updated including usage instructions.
- [x ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7447: [AIRFLOW-6821] - Success callback not called when task marked as succ…
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7447: [AIRFLOW-6821] - Success callback not called when task marked as succ…
URL: https://github.com/apache/airflow/pull/7447#issuecomment-589428802
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7447: [AIRFLOW-6821] - Success callback not called when task marked as succ…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7447: [AIRFLOW-6821] - Success callback not called when task marked as succ…
URL: https://github.com/apache/airflow/pull/7447#issuecomment-587178126
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7447?src=pr&el=h1) Report
> Merging [#7447](https://codecov.io/gh/apache/airflow/pull/7447?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d83ce260c074d3f887948921d3ebbdb1100cc800?src=pr&el=desc) will **increase** coverage by `53.41%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7447?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7447 +/- ##
===========================================
+ Coverage 32.95% 86.36% +53.41%
===========================================
Files 878 878
Lines 41219 41222 +3
===========================================
+ Hits 13584 35603 +22019
+ Misses 27635 5619 -22016
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7447?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5) | `90.12% <100%> (+67.04%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-39.44%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (+0.72%)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (+2.1%)` | :arrow_up: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <0%> (+3.37%)` | :arrow_up: |
| ... and [749 more](https://codecov.io/gh/apache/airflow/pull/7447/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7447?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7447?src=pr&el=footer). Last update [d83ce26...f0dca49](https://codecov.io/gh/apache/airflow/pull/7447?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7447: [AIRFLOW-6821] - Success callback not called when task marked as succ…
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7447: [AIRFLOW-6821] - Success callback not called when task marked as succ…
URL: https://github.com/apache/airflow/pull/7447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services