You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2007/02/15 14:16:04 UTC
svn commit: r507923 - in /tomcat/connectors/trunk/jk/native:
apache-1.3/mod_jk.c apache-2.0/mod_jk.c
Author: rjung
Date: Thu Feb 15 05:16:03 2007
New Revision: 507923
URL: http://svn.apache.org/viewvc?view=rev&rev=507923
Log:
Fix bug in adding content-length header (BZ 41610).
Analyzed and patch contributed by Boris Maras.
Modified:
tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
Modified: tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c?view=diff&rev=507923&r1=507922&r2=507923
==============================================================================
--- tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c Thu Feb 15 05:16:03 2007
@@ -702,7 +702,7 @@
s->headers_values[i] = ap_pstrdup(r->pool, elts[i].val);
s->headers_names[i] = hname;
if (need_content_length_header &&
- !strcasecmp(s->headers_values[i], "content-length")) {
+ !strcasecmp(s->headers_names[i], "content-length")) {
need_content_length_header = JK_FALSE;
}
}
Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=507923&r1=507922&r2=507923
==============================================================================
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Thu Feb 15 05:16:03 2007
@@ -730,7 +730,7 @@
s->headers_values[i] = apr_pstrdup(r->pool, elts[i].val);
s->headers_names[i] = hname;
if (need_content_length_header &&
- !strcasecmp(s->headers_values[i], "content-length")) {
+ !strcasecmp(s->headers_names[i], "content-length")) {
need_content_length_header = JK_FALSE;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r507923 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c
Posted by Henri Gomez <he...@gmail.com>.
A proof that many eyes on the same piece of code is good thing.
1.2.6 days, an eternity :)
2007/2/15, Rainer Jung <ra...@kippdata.de>:
> Mladen Turk wrote:
> > rjung@apache.org wrote:
> >> Log:
> >> Fix bug in adding content-length header (BZ 41610).
> >> Analyzed and patch contributed by Boris Maras.
> >>
> >> if (need_content_length_header &&
> >> - !strcasecmp(s->headers_values[i],
> >> "content-length")) {
> >> + !strcasecmp(s->headers_names[i],
> >> "content-length")) {
> >
> > I simply cannot believe it!
> > The faulty code originates back from 1.2.6 (or even before)...
>
> I couldn't believe it either. I'm happy, that we are getting more users
> sharing the burden of finding the glitches.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r507923 - in /tomcat/connectors/trunk/jk/native:
apache-1.3/mod_jk.c apache-2.0/mod_jk.c
Posted by Rainer Jung <ra...@kippdata.de>.
Mladen Turk wrote:
> rjung@apache.org wrote:
>> Log:
>> Fix bug in adding content-length header (BZ 41610).
>> Analyzed and patch contributed by Boris Maras.
>>
>> if (need_content_length_header &&
>> - !strcasecmp(s->headers_values[i],
>> "content-length")) {
>> + !strcasecmp(s->headers_names[i],
>> "content-length")) {
>
> I simply cannot believe it!
> The faulty code originates back from 1.2.6 (or even before)...
I couldn't believe it either. I'm happy, that we are getting more users
sharing the burden of finding the glitches.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r507923 - in /tomcat/connectors/trunk/jk/native:
apache-1.3/mod_jk.c apache-2.0/mod_jk.c
Posted by Mladen Turk <mt...@apache.org>.
rjung@apache.org wrote:
> Log:
> Fix bug in adding content-length header (BZ 41610).
> Analyzed and patch contributed by Boris Maras.
>
> if (need_content_length_header &&
> - !strcasecmp(s->headers_values[i], "content-length")) {
> + !strcasecmp(s->headers_names[i], "content-length")) {
I simply cannot believe it!
The faulty code originates back from 1.2.6 (or even before)...
Boris Maras (the guy who spotted that and provided a patch)
has a name like many Croatians have. Is it coincidence ;)
Regards,
Mladen.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org