You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/11 00:16:41 UTC

[GitHub] wkcn edited a comment on issue #12047: [MXNET-779]Add DLPack Transformation API

wkcn edited a comment on issue #12047: [MXNET-779]Add DLPack Transformation API
URL: https://github.com/apache/incubator-mxnet/pull/12047#issuecomment-420103141
 
 
   @tqchen Hi! I have updated the code as your comments. 
   I add a new constructor `NDArray(const TBlob &data, int dev_id, const std::function<void()>& deleter) ` for `NDArray class`, because the performance between `std::make_shared` and 'std::shared_ptr::shared_ptr' is different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services