[GitHub] [iceberg] szehon-ho commented on a diff in pull request #5812: Use Java collections in AwsProperties to fix Kryo serialization.

[GitBox <gi...@apache.org>]

szehon-ho commented on code in PR #5812:
URL: https://github.com/apache/iceberg/pull/5812#discussion_r1013522691


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -493,53 +492,7 @@ public class AwsProperties implements Serializable {
   private String dynamoDbEndpoint;
 
   public AwsProperties() {
-    this.httpClientType = HTTP_CLIENT_TYPE_DEFAULT;
-    this.stsClientAssumeRoleTags = Sets.newHashSet();
-
-    this.clientAssumeRoleArn = null;
-    this.clientAssumeRoleTimeoutSec = CLIENT_ASSUME_ROLE_TIMEOUT_SEC_DEFAULT;
-    this.clientAssumeRoleExternalId = null;
-    this.clientAssumeRoleRegion = null;
-    this.clientAssumeRoleSessionName = null;
-
-    this.s3FileIoSseType = S3FILEIO_SSE_TYPE_NONE;
-    this.s3FileIoSseKey = null;
-    this.s3FileIoSseMd5 = null;
-    this.s3AccessKeyId = null;
-    this.s3SecretAccessKey = null;
-    this.s3SessionToken = null;
-    this.s3FileIoAcl = null;
-    this.s3Endpoint = null;
-
-    this.s3FileIoMultipartUploadThreads = Runtime.getRuntime().availableProcessors();
-    this.s3FileIoMultiPartSize = S3FILEIO_MULTIPART_SIZE_DEFAULT;
-    this.s3FileIoMultipartThresholdFactor = S3FILEIO_MULTIPART_THRESHOLD_FACTOR_DEFAULT;
-    this.s3FileIoDeleteBatchSize = S3FILEIO_DELETE_BATCH_SIZE_DEFAULT;
-    this.s3fileIoStagingDirectory = System.getProperty("java.io.tmpdir");
-    this.isS3ChecksumEnabled = S3_CHECKSUM_ENABLED_DEFAULT;
-    this.s3WriteTags = Sets.newHashSet();
-    this.s3DeleteTags = Sets.newHashSet();
-    this.s3FileIoDeleteThreads = Runtime.getRuntime().availableProcessors();
-    this.isS3DeleteEnabled = S3_DELETE_ENABLED_DEFAULT;
-    this.s3BucketToAccessPointMapping = ImmutableMap.of();

Review Comment:
   Can we just change this line instead of replacing whole CTOR?  If I understand, its the one causing issue?
   
    I realize its same thing but it makes a bigger code change and I guess this version was supposed to be optimized to avoid PropertyUtil calls?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org