[GitHub] [arrow] westonpace commented on a diff in pull request #12228: ARROW-15410: [C++][Datasets] Improve memory usage of datasets API when scanning parquet

[GitBox <gi...@apache.org>]

westonpace commented on code in PR #12228:
URL: https://github.com/apache/arrow/pull/12228#discussion_r855737474


##########
cpp/src/arrow/compute/exec/hash_join_node.cc:
##########
@@ -593,9 +593,13 @@ class HashJoinNode : public ExecNode {
     return Status::OK();
   }
 
-  void PauseProducing(ExecNode* output) override { EVENT(span_, "PauseProducing"); }
+  void PauseProducing(ExecNode* output, int32_t counter) override {
+    // TODO(ARROW-16246)

Review Comment:
   I'm not really a fan of these if we're not actually doing anything (or just proxying info) but I can put it back in.  In general I think `EVENT` is more meaningful when we've made some kind of decision based on data (e.g. when we decide we need to apply backpressure) or an external signal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org