You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/15 12:37:57 UTC
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6274: Fix typo error: XXX_DYNTIMEO_YYY to XXX_DYNTIMEOUT_YYY
pkarashchenko commented on code in PR #6274:
URL: https://github.com/apache/incubator-nuttx/pull/6274#discussion_r873163197
##########
arch/arm/src/efm32/efm32_i2c.c:
##########
@@ -513,7 +513,7 @@ static useconds_t efm32_i2c_tousecs(int msgc, struct i2c_msg_s *msgs)
* factor.
*/
- return (useconds_t) (CONFIG_EFM32_I2C_DYNTIMEO_USECPERBYTE * bytecount);
+ return (useconds_t) (CONFIG_EFM32_I2C_DYNTIMEOUT_USECPERBYTE * bytecount);
Review Comment:
Oah... I didn't expect so radical changes.
I think thinking only about changing
```
#ifdef CONFIG_EFM32_I2C_DYNTIMEOUT
static useconds_t efm32_i2c_tousecs(int msgc, struct i2c_msg_s *msgs);
#endif /* CONFIG_EFM32_I2C_DYNTIMEOUT */
```
to
```
#ifdef CONFIG_EFM32_I2C_DYNTIMEO
static useconds_t efm32_i2c_tousecs(int msgc, struct i2c_msg_s *msgs);
#endif /* CONFIG_EFM32_I2C_DYNTIMEO */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org