You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Blake Watson <bl...@pnmac.com> on 2018/03/24 00:56:52 UTC
Adding a function or two...
I was going to try adding functions to POI (IFNA seems like a likely first
shot). I've imported the sources from the ZIP (NetBeans) and I can build
and run tests. But I don't see where the source code for the tests is. (I
assume I start with the tests...)
Also open to any suggestions for...whatever.
--
*Blake Watson*
*PNMAC*
Application Development Manager
5898 Condor Drive
Moorpark, CA 93021
(805) 330.4911 x7742
blake.watson@pnmac.com
www.PennyMacUSA.com <http://www.pennymacusa.com/>
Re: Adding a function or two...
Posted by Ross Patterson <ro...@gmail.com>.
It's been a few years since Blake was going to try implementing IFNA(), and it appears not to have happened. I needed it, and I have an implementation, but I'm having problems with testing it. I've got a unit test (TestIfna.java), built similarly to lots of other function tests, and it passes. But my attempt to test using IFNA() in a spreadsheet (TestIfnaFromSpreadsheet.java) acts as if the function isn't defined:
Testcase: org.apache.poi.ss.formula.functions.TestIfnaFromSpreadsheet
Test: processFunctionRow(String, String, HSSFSheet, int, HSSFFormulaEvaluator, int)[1] took 140 milli sec(s) FAILED: In IfnaTestCaseData.xls Ifna!B5 {=_xlfn.IFNA(E5,F5)} 'An N/A value' - exception in evaluator.evaluate(evalCell): org.apache.poi.ss.formula.eval.NotImplementedException: Error evaluating cell Ifna!B5 with inner exception: org.apache.poi.ss.formula.eval.NotImplementedFunctionException: _xlfn.IFNA
org.apache.poi.ss.formula.eval.NotImplementedFunctionException: _xlfn.IFNA
..
This is a surprise, because I've updated FunctionEval.java and functionMetadata.txt to define it. I followed the "Developing Formula Evaluation" instructions at https://poi.apache.org/components/spreadsheet/eval-devguide.html, but I've clearly missed a step. Where should I be looking? Is there a decent example of a patch that adds a new function?
FYI, I'm working with the 5.0.0 code from GitHub, because I can't get the trunk to build in Eclipse. I figure when I'm done, I can patch the changes over to trunk and submit the patch to the project.
Ross
On 2018/03/28 15:37:24, Blake Watson <bl...@pnmac.com> wrote:
> Cool! Thanks for the info!
>
> On Tue, Mar 27, 2018 at 8:33 PM, Javen O'Neal <on...@apache.org> wrote:
>
> > HSSF and SS Common tests live here:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__svn.
> > apache.org_viewvc_poi_trunk_src_testcases_org_apache_poi_&d=DwIBaQ&c=
> > dmLomitc30UP5j2qU8E1rg&r=p42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=
> > 9FntbrfQ5DHbCbbD4dHRFd-jEvVS_DFaN2jfCRuqkts&s=
> > LGupNdlEvUmSUdmJQ7wav8Vo9t8avrWemrKY-yvbrPE&e=
> >
> > XSSF and SS Common tests live here:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__svn.
> > apache.org_viewvc_poi_trunk_src_ooxml_testcases_org_
> > apache_poi_&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=
> > p42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=
> > 9FntbrfQ5DHbCbbD4dHRFd-jEvVS_DFaN2jfCRuqkts&s=TY5huEEOZnHwkZT9MfQF-
> > 5c46UCr46zSgJzH9efj7Vk&e=
> >
> > We separated the tests because HSSF code is compiled and tested without
> > providing ooxml-schema.jar or poi-ooxml-schema.jar on the class path. This
> > way we can guarantee that poi.jar doesn't require ooxml as a dependency, to
> > keep projects small where they're only using the binary formats.
> >
> > On Tue, Mar 27, 2018, 20:09 Blake Watson <bl...@pnmac.com> wrote:
> >
> > > I was just scouring the whole project for XSSFWorkbook and not finding
> > > nearly as much as I thought.
> > >
> > > How does one properly add to functionMetaData.txt?
> > >
> > > On Tue, Mar 27, 2018 at 6:38 PM, Greg Woolsey <gr...@gmail.com>
> > > wrote:
> > >
> > > > Tests in that package are run in a context without the xssf code. Xssf
> > > > specific tests need to go in a different location. I don't have it on
> > my
> > > > phone, but some searching should reveal them, the naming conventions
> > are
> > > > strong.
> > > >
> > > > On Tue, Mar 27, 2018, 17:45 Blake Watson <bl...@pnmac.com>
> > wrote:
> > > >
> > > > > The tests seem to be mostly HSSF based. Is that right? (I guess it
> > > > > shouldn't matter?)
> > > > >
> > > > > On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson <
> > blake.watson@pnmac.com>
> > > > > wrote:
> > > > >
> > > > > > Yeah, I was gonna use the Git.
> > > > > >
> > > > > > On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <
> > > > > dominik.stadler@gmx.at>
> > > > > > wrote:
> > > > > >
> > > > > >> Hi,
> > > > > >>
> > > > > >> Tests are part of the published sources in separate directories
> > > under
> > > > > >> "src", for functions mostly under "src/testsources", e.g.
> > > > > >> src/testcases/org/apache/poi/ss/formula/functions seems a good
> > place
> > > > for
> > > > > >> unit-tests that cover specific functions.
> > > > > >>
> > > > > >> Maybe also good if you use either the SVN or Git repository
> > > directly,
> > > > > then
> > > > > >> it is easier to contribute changes as patch or pull-request.
> > > > > >>
> > > > > >> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > > > > >> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > > > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > > > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
> > > > > >> LO7ywUomDopdFrs&e= and
> > > > > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > > > > >> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > > > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > > > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
> > > > > >> 87GDNNpu7RkO50Q&e= for working with the code,
> > > > > >>
> > > > > >> Thanks... Dominik.
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson <
> > > blake.watson@pnmac.com
> > > > >
> > > > > >> wrote:
> > > > > >>
> > > > > >> > I was going to try adding functions to POI (IFNA seems like a
> > > likely
> > > > > >> first
> > > > > >> > shot). I've imported the sources from the ZIP (NetBeans) and I
> > can
> > > > > build
> > > > > >> > and run tests. But I don't see where the source code for the
> > tests
> > > > is.
> > > > > >> (I
> > > > > >> > assume I start with the tests...)
> > > > > >> >
> > > > > >> > Also open to any suggestions for...whatever.
> > > > > >> > --
> > > > > >> >
> > > > > >> > *Blake Watson*
> > > > > >> >
> > > > > >> > *PNMAC*
> > > > > >> > Application Development Manager
> > > > > >> > 5898 Condor Drive
> > > > > >> > Moorpark, CA 93021
> > > > > >> > (805) 330.4911 x7742
> > > > > >> > blake.watson@pnmac.com
> > > > > >> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > > > > >> >
> > > > > >>
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > >
> > > > > > *Blake Watson*
> > > > > >
> > > > > > *PNMAC*
> > > > > > Application Development Manager
> > > > > > 5898 Condor Drive
> > > > > > Moorpark, CA 93021
> > > > > > (805) 330.4911 x7742
> > > > > > blake.watson@pnmac.com
> > > > > > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > >
> > > > > *Blake Watson*
> > > > >
> > > > > *PNMAC*
> > > > > Application Development Manager
> > > > > 5898 Condor Drive
> > > > > Moorpark, CA 93021
> > > > > (805) 330.4911 x7742
> > > > > blake.watson@pnmac.com
> > > > > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > *Blake Watson*
> > >
> > > *PNMAC*
> > > Application Development Manager
> > > 5898 Condor Drive
> > > Moorpark, CA 93021
> > > (805) 330.4911 x7742
> > > blake.watson@pnmac.com
> > > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > >
> >
>
>
>
> --
>
> *Blake Watson*
>
> *PNMAC*
> Application Development Manager
> 5898 Condor Drive
> Moorpark, CA 93021
> (805) 330.4911 x7742
> blake.watson@pnmac.com
> www.PennyMacUSA.com <http://www.pennymacusa.com/>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: Adding a function or two...
Posted by Blake Watson <bl...@pnmac.com>.
Cool! Thanks for the info!
On Tue, Mar 27, 2018 at 8:33 PM, Javen O'Neal <on...@apache.org> wrote:
> HSSF and SS Common tests live here:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__svn.
> apache.org_viewvc_poi_trunk_src_testcases_org_apache_poi_&d=DwIBaQ&c=
> dmLomitc30UP5j2qU8E1rg&r=p42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=
> 9FntbrfQ5DHbCbbD4dHRFd-jEvVS_DFaN2jfCRuqkts&s=
> LGupNdlEvUmSUdmJQ7wav8Vo9t8avrWemrKY-yvbrPE&e=
>
> XSSF and SS Common tests live here:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__svn.
> apache.org_viewvc_poi_trunk_src_ooxml_testcases_org_
> apache_poi_&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=
> p42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=
> 9FntbrfQ5DHbCbbD4dHRFd-jEvVS_DFaN2jfCRuqkts&s=TY5huEEOZnHwkZT9MfQF-
> 5c46UCr46zSgJzH9efj7Vk&e=
>
> We separated the tests because HSSF code is compiled and tested without
> providing ooxml-schema.jar or poi-ooxml-schema.jar on the class path. This
> way we can guarantee that poi.jar doesn't require ooxml as a dependency, to
> keep projects small where they're only using the binary formats.
>
> On Tue, Mar 27, 2018, 20:09 Blake Watson <bl...@pnmac.com> wrote:
>
> > I was just scouring the whole project for XSSFWorkbook and not finding
> > nearly as much as I thought.
> >
> > How does one properly add to functionMetaData.txt?
> >
> > On Tue, Mar 27, 2018 at 6:38 PM, Greg Woolsey <gr...@gmail.com>
> > wrote:
> >
> > > Tests in that package are run in a context without the xssf code. Xssf
> > > specific tests need to go in a different location. I don't have it on
> my
> > > phone, but some searching should reveal them, the naming conventions
> are
> > > strong.
> > >
> > > On Tue, Mar 27, 2018, 17:45 Blake Watson <bl...@pnmac.com>
> wrote:
> > >
> > > > The tests seem to be mostly HSSF based. Is that right? (I guess it
> > > > shouldn't matter?)
> > > >
> > > > On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson <
> blake.watson@pnmac.com>
> > > > wrote:
> > > >
> > > > > Yeah, I was gonna use the Git.
> > > > >
> > > > > On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <
> > > > dominik.stadler@gmx.at>
> > > > > wrote:
> > > > >
> > > > >> Hi,
> > > > >>
> > > > >> Tests are part of the published sources in separate directories
> > under
> > > > >> "src", for functions mostly under "src/testsources", e.g.
> > > > >> src/testcases/org/apache/poi/ss/formula/functions seems a good
> place
> > > for
> > > > >> unit-tests that cover specific functions.
> > > > >>
> > > > >> Maybe also good if you use either the SVN or Git repository
> > directly,
> > > > then
> > > > >> it is easier to contribute changes as patch or pull-request.
> > > > >>
> > > > >> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > > > >> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
> > > > >> LO7ywUomDopdFrs&e= and
> > > > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > > > >> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
> > > > >> 87GDNNpu7RkO50Q&e= for working with the code,
> > > > >>
> > > > >> Thanks... Dominik.
> > > > >>
> > > > >>
> > > > >>
> > > > >> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson <
> > blake.watson@pnmac.com
> > > >
> > > > >> wrote:
> > > > >>
> > > > >> > I was going to try adding functions to POI (IFNA seems like a
> > likely
> > > > >> first
> > > > >> > shot). I've imported the sources from the ZIP (NetBeans) and I
> can
> > > > build
> > > > >> > and run tests. But I don't see where the source code for the
> tests
> > > is.
> > > > >> (I
> > > > >> > assume I start with the tests...)
> > > > >> >
> > > > >> > Also open to any suggestions for...whatever.
> > > > >> > --
> > > > >> >
> > > > >> > *Blake Watson*
> > > > >> >
> > > > >> > *PNMAC*
> > > > >> > Application Development Manager
> > > > >> > 5898 Condor Drive
> > > > >> > Moorpark, CA 93021
> > > > >> > (805) 330.4911 x7742
> > > > >> > blake.watson@pnmac.com
> > > > >> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > > > >> >
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > >
> > > > > *Blake Watson*
> > > > >
> > > > > *PNMAC*
> > > > > Application Development Manager
> > > > > 5898 Condor Drive
> > > > > Moorpark, CA 93021
> > > > > (805) 330.4911 x7742
> > > > > blake.watson@pnmac.com
> > > > > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > >
> > > > *Blake Watson*
> > > >
> > > > *PNMAC*
> > > > Application Development Manager
> > > > 5898 Condor Drive
> > > > Moorpark, CA 93021
> > > > (805) 330.4911 x7742
> > > > blake.watson@pnmac.com
> > > > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > > >
> > >
> >
> >
> >
> > --
> >
> > *Blake Watson*
> >
> > *PNMAC*
> > Application Development Manager
> > 5898 Condor Drive
> > Moorpark, CA 93021
> > (805) 330.4911 x7742
> > blake.watson@pnmac.com
> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> >
>
--
*Blake Watson*
*PNMAC*
Application Development Manager
5898 Condor Drive
Moorpark, CA 93021
(805) 330.4911 x7742
blake.watson@pnmac.com
www.PennyMacUSA.com <http://www.pennymacusa.com/>
Re: Adding a function or two...
Posted by Javen O'Neal <on...@apache.org>.
HSSF and SS Common tests live here:
https://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/
XSSF and SS Common tests live here:
https://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/
We separated the tests because HSSF code is compiled and tested without
providing ooxml-schema.jar or poi-ooxml-schema.jar on the class path. This
way we can guarantee that poi.jar doesn't require ooxml as a dependency, to
keep projects small where they're only using the binary formats.
On Tue, Mar 27, 2018, 20:09 Blake Watson <bl...@pnmac.com> wrote:
> I was just scouring the whole project for XSSFWorkbook and not finding
> nearly as much as I thought.
>
> How does one properly add to functionMetaData.txt?
>
> On Tue, Mar 27, 2018 at 6:38 PM, Greg Woolsey <gr...@gmail.com>
> wrote:
>
> > Tests in that package are run in a context without the xssf code. Xssf
> > specific tests need to go in a different location. I don't have it on my
> > phone, but some searching should reveal them, the naming conventions are
> > strong.
> >
> > On Tue, Mar 27, 2018, 17:45 Blake Watson <bl...@pnmac.com> wrote:
> >
> > > The tests seem to be mostly HSSF based. Is that right? (I guess it
> > > shouldn't matter?)
> > >
> > > On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson <bl...@pnmac.com>
> > > wrote:
> > >
> > > > Yeah, I was gonna use the Git.
> > > >
> > > > On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <
> > > dominik.stadler@gmx.at>
> > > > wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> Tests are part of the published sources in separate directories
> under
> > > >> "src", for functions mostly under "src/testsources", e.g.
> > > >> src/testcases/org/apache/poi/ss/formula/functions seems a good place
> > for
> > > >> unit-tests that cover specific functions.
> > > >>
> > > >> Maybe also good if you use either the SVN or Git repository
> directly,
> > > then
> > > >> it is easier to contribute changes as patch or pull-request.
> > > >>
> > > >> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > > >> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
> > > >> LO7ywUomDopdFrs&e= and
> > > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > > >> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
> > > >> 87GDNNpu7RkO50Q&e= for working with the code,
> > > >>
> > > >> Thanks... Dominik.
> > > >>
> > > >>
> > > >>
> > > >> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson <
> blake.watson@pnmac.com
> > >
> > > >> wrote:
> > > >>
> > > >> > I was going to try adding functions to POI (IFNA seems like a
> likely
> > > >> first
> > > >> > shot). I've imported the sources from the ZIP (NetBeans) and I can
> > > build
> > > >> > and run tests. But I don't see where the source code for the tests
> > is.
> > > >> (I
> > > >> > assume I start with the tests...)
> > > >> >
> > > >> > Also open to any suggestions for...whatever.
> > > >> > --
> > > >> >
> > > >> > *Blake Watson*
> > > >> >
> > > >> > *PNMAC*
> > > >> > Application Development Manager
> > > >> > 5898 Condor Drive
> > > >> > Moorpark, CA 93021
> > > >> > (805) 330.4911 x7742
> > > >> > blake.watson@pnmac.com
> > > >> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > > >> >
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > >
> > > > *Blake Watson*
> > > >
> > > > *PNMAC*
> > > > Application Development Manager
> > > > 5898 Condor Drive
> > > > Moorpark, CA 93021
> > > > (805) 330.4911 x7742
> > > > blake.watson@pnmac.com
> > > > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > *Blake Watson*
> > >
> > > *PNMAC*
> > > Application Development Manager
> > > 5898 Condor Drive
> > > Moorpark, CA 93021
> > > (805) 330.4911 x7742
> > > blake.watson@pnmac.com
> > > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > >
> >
>
>
>
> --
>
> *Blake Watson*
>
> *PNMAC*
> Application Development Manager
> 5898 Condor Drive
> Moorpark, CA 93021
> (805) 330.4911 x7742
> blake.watson@pnmac.com
> www.PennyMacUSA.com <http://www.pennymacusa.com/>
>
Re: Adding a function or two...
Posted by Blake Watson <bl...@pnmac.com>.
I was just scouring the whole project for XSSFWorkbook and not finding
nearly as much as I thought.
How does one properly add to functionMetaData.txt?
On Tue, Mar 27, 2018 at 6:38 PM, Greg Woolsey <gr...@gmail.com>
wrote:
> Tests in that package are run in a context without the xssf code. Xssf
> specific tests need to go in a different location. I don't have it on my
> phone, but some searching should reveal them, the naming conventions are
> strong.
>
> On Tue, Mar 27, 2018, 17:45 Blake Watson <bl...@pnmac.com> wrote:
>
> > The tests seem to be mostly HSSF based. Is that right? (I guess it
> > shouldn't matter?)
> >
> > On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson <bl...@pnmac.com>
> > wrote:
> >
> > > Yeah, I was gonna use the Git.
> > >
> > > On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <
> > dominik.stadler@gmx.at>
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> Tests are part of the published sources in separate directories under
> > >> "src", for functions mostly under "src/testsources", e.g.
> > >> src/testcases/org/apache/poi/ss/formula/functions seems a good place
> for
> > >> unit-tests that cover specific functions.
> > >>
> > >> Maybe also good if you use either the SVN or Git repository directly,
> > then
> > >> it is easier to contribute changes as patch or pull-request.
> > >>
> > >> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > >> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
> > >> LO7ywUomDopdFrs&e= and
> > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> > >> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
> > >> 87GDNNpu7RkO50Q&e= for working with the code,
> > >>
> > >> Thanks... Dominik.
> > >>
> > >>
> > >>
> > >> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson <blake.watson@pnmac.com
> >
> > >> wrote:
> > >>
> > >> > I was going to try adding functions to POI (IFNA seems like a likely
> > >> first
> > >> > shot). I've imported the sources from the ZIP (NetBeans) and I can
> > build
> > >> > and run tests. But I don't see where the source code for the tests
> is.
> > >> (I
> > >> > assume I start with the tests...)
> > >> >
> > >> > Also open to any suggestions for...whatever.
> > >> > --
> > >> >
> > >> > *Blake Watson*
> > >> >
> > >> > *PNMAC*
> > >> > Application Development Manager
> > >> > 5898 Condor Drive
> > >> > Moorpark, CA 93021
> > >> > (805) 330.4911 x7742
> > >> > blake.watson@pnmac.com
> > >> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > >> >
> > >>
> > >
> > >
> > >
> > > --
> > >
> > > *Blake Watson*
> > >
> > > *PNMAC*
> > > Application Development Manager
> > > 5898 Condor Drive
> > > Moorpark, CA 93021
> > > (805) 330.4911 x7742
> > > blake.watson@pnmac.com
> > > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> > >
> >
> >
> >
> > --
> >
> > *Blake Watson*
> >
> > *PNMAC*
> > Application Development Manager
> > 5898 Condor Drive
> > Moorpark, CA 93021
> > (805) 330.4911 x7742
> > blake.watson@pnmac.com
> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> >
>
--
*Blake Watson*
*PNMAC*
Application Development Manager
5898 Condor Drive
Moorpark, CA 93021
(805) 330.4911 x7742
blake.watson@pnmac.com
www.PennyMacUSA.com <http://www.pennymacusa.com/>
Re: Adding a function or two...
Posted by Greg Woolsey <gr...@gmail.com>.
Tests in that package are run in a context without the xssf code. Xssf
specific tests need to go in a different location. I don't have it on my
phone, but some searching should reveal them, the naming conventions are
strong.
On Tue, Mar 27, 2018, 17:45 Blake Watson <bl...@pnmac.com> wrote:
> The tests seem to be mostly HSSF based. Is that right? (I guess it
> shouldn't matter?)
>
> On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson <bl...@pnmac.com>
> wrote:
>
> > Yeah, I was gonna use the Git.
> >
> > On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <
> dominik.stadler@gmx.at>
> > wrote:
> >
> >> Hi,
> >>
> >> Tests are part of the published sources in separate directories under
> >> "src", for functions mostly under "src/testsources", e.g.
> >> src/testcases/org/apache/poi/ss/formula/functions seems a good place for
> >> unit-tests that cover specific functions.
> >>
> >> Maybe also good if you use either the SVN or Git repository directly,
> then
> >> it is easier to contribute changes as patch or pull-request.
> >>
> >> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> >> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
> >> LO7ywUomDopdFrs&e= and
> >> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
> >> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
> >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
> >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
> >> 87GDNNpu7RkO50Q&e= for working with the code,
> >>
> >> Thanks... Dominik.
> >>
> >>
> >>
> >> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson <bl...@pnmac.com>
> >> wrote:
> >>
> >> > I was going to try adding functions to POI (IFNA seems like a likely
> >> first
> >> > shot). I've imported the sources from the ZIP (NetBeans) and I can
> build
> >> > and run tests. But I don't see where the source code for the tests is.
> >> (I
> >> > assume I start with the tests...)
> >> >
> >> > Also open to any suggestions for...whatever.
> >> > --
> >> >
> >> > *Blake Watson*
> >> >
> >> > *PNMAC*
> >> > Application Development Manager
> >> > 5898 Condor Drive
> >> > Moorpark, CA 93021
> >> > (805) 330.4911 x7742
> >> > blake.watson@pnmac.com
> >> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> >> >
> >>
> >
> >
> >
> > --
> >
> > *Blake Watson*
> >
> > *PNMAC*
> > Application Development Manager
> > 5898 Condor Drive
> > Moorpark, CA 93021
> > (805) 330.4911 x7742
> > blake.watson@pnmac.com
> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> >
>
>
>
> --
>
> *Blake Watson*
>
> *PNMAC*
> Application Development Manager
> 5898 Condor Drive
> Moorpark, CA 93021
> (805) 330.4911 x7742
> blake.watson@pnmac.com
> www.PennyMacUSA.com <http://www.pennymacusa.com/>
>
Re: Adding a function or two...
Posted by Blake Watson <bl...@pnmac.com>.
The tests seem to be mostly HSSF based. Is that right? (I guess it
shouldn't matter?)
On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson <bl...@pnmac.com>
wrote:
> Yeah, I was gonna use the Git.
>
> On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <do...@gmx.at>
> wrote:
>
>> Hi,
>>
>> Tests are part of the published sources in separate directories under
>> "src", for functions mostly under "src/testsources", e.g.
>> src/testcases/org/apache/poi/ss/formula/functions seems a good place for
>> unit-tests that cover specific functions.
>>
>> Maybe also good if you use either the SVN or Git repository directly, then
>> it is easier to contribute changes as patch or pull-request.
>>
>> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
>> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
>> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
>> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g
>> LO7ywUomDopdFrs&e= and
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac
>> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p
>> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy
>> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN
>> 87GDNNpu7RkO50Q&e= for working with the code,
>>
>> Thanks... Dominik.
>>
>>
>>
>> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson <bl...@pnmac.com>
>> wrote:
>>
>> > I was going to try adding functions to POI (IFNA seems like a likely
>> first
>> > shot). I've imported the sources from the ZIP (NetBeans) and I can build
>> > and run tests. But I don't see where the source code for the tests is.
>> (I
>> > assume I start with the tests...)
>> >
>> > Also open to any suggestions for...whatever.
>> > --
>> >
>> > *Blake Watson*
>> >
>> > *PNMAC*
>> > Application Development Manager
>> > 5898 Condor Drive
>> > Moorpark, CA 93021
>> > (805) 330.4911 x7742
>> > blake.watson@pnmac.com
>> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
>> >
>>
>
>
>
> --
>
> *Blake Watson*
>
> *PNMAC*
> Application Development Manager
> 5898 Condor Drive
> Moorpark, CA 93021
> (805) 330.4911 x7742
> blake.watson@pnmac.com
> www.PennyMacUSA.com <http://www.pennymacusa.com/>
>
--
*Blake Watson*
*PNMAC*
Application Development Manager
5898 Condor Drive
Moorpark, CA 93021
(805) 330.4911 x7742
blake.watson@pnmac.com
www.PennyMacUSA.com <http://www.pennymacusa.com/>
Re: Adding a function or two...
Posted by Blake Watson <bl...@pnmac.com>.
Yeah, I was gonna use the Git.
On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler <do...@gmx.at>
wrote:
> Hi,
>
> Tests are part of the published sources in separate directories under
> "src", for functions mostly under "src/testsources", e.g.
> src/testcases/org/apache/poi/ss/formula/functions seems a good place for
> unit-tests that cover specific functions.
>
> Maybe also good if you use either the SVN or Git repository directly, then
> it is easier to contribute changes as patch or pull-request.
>
> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.
> apache.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=
> p42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=
> 1DnAqaPgydsOffypXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_
> gLO7ywUomDopdFrs&e= and
> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.
> apache.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=
> p42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=
> 1DnAqaPgydsOffypXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-
> JjkVJMUqN87GDNNpu7RkO50Q&e= for working with the code,
>
> Thanks... Dominik.
>
>
>
> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson <bl...@pnmac.com>
> wrote:
>
> > I was going to try adding functions to POI (IFNA seems like a likely
> first
> > shot). I've imported the sources from the ZIP (NetBeans) and I can build
> > and run tests. But I don't see where the source code for the tests is. (I
> > assume I start with the tests...)
> >
> > Also open to any suggestions for...whatever.
> > --
> >
> > *Blake Watson*
> >
> > *PNMAC*
> > Application Development Manager
> > 5898 Condor Drive
> > Moorpark, CA 93021
> > (805) 330.4911 x7742
> > blake.watson@pnmac.com
> > www.PennyMacUSA.com <http://www.pennymacusa.com/>
> >
>
--
*Blake Watson*
*PNMAC*
Application Development Manager
5898 Condor Drive
Moorpark, CA 93021
(805) 330.4911 x7742
blake.watson@pnmac.com
www.PennyMacUSA.com <http://www.pennymacusa.com/>
Re: Adding a function or two...
Posted by Dominik Stadler <do...@gmx.at>.
Hi,
Tests are part of the published sources in separate directories under
"src", for functions mostly under "src/testsources", e.g.
src/testcases/org/apache/poi/ss/formula/functions seems a good place for
unit-tests that cover specific functions.
Maybe also good if you use either the SVN or Git repository directly, then
it is easier to contribute changes as patch or pull-request.
See http://poi.apache.org/subversion.html and
http://poi.apache.org/howtobuild.html for working with the code,
Thanks... Dominik.
On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson <bl...@pnmac.com>
wrote:
> I was going to try adding functions to POI (IFNA seems like a likely first
> shot). I've imported the sources from the ZIP (NetBeans) and I can build
> and run tests. But I don't see where the source code for the tests is. (I
> assume I start with the tests...)
>
> Also open to any suggestions for...whatever.
> --
>
> *Blake Watson*
>
> *PNMAC*
> Application Development Manager
> 5898 Condor Drive
> Moorpark, CA 93021
> (805) 330.4911 x7742
> blake.watson@pnmac.com
> www.PennyMacUSA.com <http://www.pennymacusa.com/>
>