You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Terasaka Kinya (Created) (JIRA)" <ji...@apache.org> on 2012/03/28 10:40:34 UTC

[jira] [Created] (WICKET-4480) newResourceResponse() always process IResourceStream

newResourceResponse() always process IResourceStream
----------------------------------------------------

                 Key: WICKET-4480
                 URL: https://issues.apache.org/jira/browse/WICKET-4480
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 6.0.0-beta1, 1.5.5
            Reporter: Terasaka Kinya
            Priority: Minor


The conditional statement 'if (resourceResponse.dataNeedsToBeWritten(attributes))' in PackageResource$newResourceResponse always turns true.

dataNeedsToBeWritten() method internally uses its own lastModified field, which is null (by default) and always returns true at that point resulting in getting a stream and processing it every time.

I think this ruins resource caching.

NOTE: The API document of dataNeedsToBeWritten() exclaims setLastModified() be called first.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-4480) newResourceResponse() always process IResourceStream

Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/WICKET-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4480.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 6.0.0-RC1
                   1.5.6
         Assignee: Martin Grigorov
    
> newResourceResponse() always process IResourceStream
> ----------------------------------------------------
>
>                 Key: WICKET-4480
>                 URL: https://issues.apache.org/jira/browse/WICKET-4480
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.5, 6.0.0-beta1
>            Reporter: Terasaka Kinya
>            Assignee: Martin Grigorov
>            Priority: Minor
>              Labels: cache, resource
>             Fix For: 1.5.6, 6.0.0-RC1
>
>
> The conditional statement 'if (resourceResponse.dataNeedsToBeWritten(attributes))' in PackageResource$newResourceResponse always turns true.
> dataNeedsToBeWritten() method internally uses its own lastModified field, which is null (by default) and always returns true at that point resulting in getting a stream and processing it every time.
> I think this ruins resource caching.
> NOTE: The API document of dataNeedsToBeWritten() exclaims setLastModified() be called first.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira