[GitHub] [iceberg] pvary commented on a change in pull request #2086: Hive: Schema conversion should convert field comments

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2086:
URL: https://github.com/apache/iceberg/pull/2086#discussion_r556648080



##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -150,6 +151,19 @@ public void testScanTable() throws IOException {
     Assert.assertArrayEquals(new Object[] {"Alice", 0L}, descRows.get(2));
   }
 
+  @Test
+  public void testDescribeTable() throws IOException {

Review comment:
       It would be good to have a test for:
   ```
   CREATE TABLE alma (korte INT COMMENT 'barack')
   ```
   
   I think the change need to be done here:
   https://github.com/apache/iceberg/blob/969a1ffc8d7392cc4c54eba156647c448757b45e/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java#L135-L153




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org