You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by tibkiss <gi...@git.apache.org> on 2016/07/20 12:59:11 UTC
[GitHub] storm pull request #1579: STORM-1989: X-Frame-Options support for Storm UI
GitHub user tibkiss opened a pull request:
https://github.com/apache/storm/pull/1579
STORM-1989: X-Frame-Options support for Storm UI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tibkiss/storm feature/x-frame-options-support-in-ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1579.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1579
----
commit 4e2e4a990183ceee73009de60e5eafabeb11baa2
Author: Tibor Kiss <ti...@gmail.com>
Date: 2016-07-19T11:40:36Z
Implement HTTP X-Frame-Options for Storm UI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1579: STORM-1989: X-Frame-Options support for Storm UI
Posted by tibkiss <gi...@git.apache.org>.
Github user tibkiss commented on the issue:
https://github.com/apache/storm/pull/1579
Thanks @ptgoetz for the review!
The Travis test failure seems unrelated to me:
The base version of the patch also fails with test errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1579: STORM-1989: X-Frame-Options support for Storm UI
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1579
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1579: STORM-1989: X-Frame-Options support for Storm UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1579: STORM-1989: X-Frame-Options support for Storm UI
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1579
@tibkiss Yes. I tested locally and the build succeeded.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1579: STORM-1989: X-Frame-Options support for Storm UI
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1579
@tibkiss can you post a patch against 1.x-branch as well. Also how does this works with CORS enabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1579: STORM-1989: X-Frame-Options support for Storm UI
Posted by tibkiss <gi...@git.apache.org>.
Github user tibkiss commented on the issue:
https://github.com/apache/storm/pull/1579
@harshach : The patch is not interfering with CORS filter. It is an additional filter addressing the ClickJacking vulnerability.
@ptgoetz : Super thanks for merging the PR to both branches. Next time I'll address the delivery to additional branches quicker.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---