You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/23 01:46:12 UTC
[GitHub] [flink-kubernetes-operator] JaeguKim edited a comment on pull request #97: Fix development guide document
JaeguKim edited a comment on pull request #97:
URL: https://github.com/apache/flink-kubernetes-operator/pull/97#issuecomment-1075818223
Development guide is using both [flink-operator](https://github.com/apache/flink-kubernetes-operator/blob/9fe5d25e4d780d22fba1d1853b422ed8d31e6e01/docs/content/docs/development/guide.md?plain=1#L51-L54) and [flink-java-operator](https://github.com/apache/flink-kubernetes-operator/blob/9fe5d25e4d780d22fba1d1853b422ed8d31e6e01/docs/content/docs/development/guide.md?plain=1#L40-L47) for docker repo name. So I thought using one uniform name would be good idea.
And `image.repository` field needs to be `<repo>/flink-operator` or `<repo>/flink-java-operator`. If not, pod can't pull the image.
I guess [repo name](https://github.com/apache/flink-kubernetes-operator/blob/9fe5d25e4d780d22fba1d1853b422ed8d31e6e01/helm/flink-operator/values.yaml#L26) of helm chart needs to be `<hub-user>/<repo-name>` form but it seems [FLINK-26214](https://issues.apache.org/jira/browse/FLINK-26214) needs to be done first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org