You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladi99 (via GitHub)" <gi...@apache.org> on 2023/06/29 12:04:39 UTC

[GitHub] [airflow] eladi99 commented on a diff in pull request #32259: Fix `LambdaInvokeFunctionOperator` payload parameter type

eladi99 commented on code in PR #32259:
URL: https://github.com/apache/airflow/pull/32259#discussion_r1246528831


##########
tests/system/providers/amazon/aws/example_lambda.py:
##########
@@ -103,7 +103,7 @@ def delete_lambda(function_name: str):
     invoke_lambda_function = LambdaInvokeFunctionOperator(
         task_id="invoke_lambda_function",
         function_name=lambda_function_name,
-        payload=json.dumps({"SampleEvent": {"SampleData": {"Name": "XYZ", "DoB": "1993-01-01"}}}),
+        payload=json.dumps({"SampleEvent": {"SampleData": {"Name": "XYZ", "DoB": "1993-01-01"}}}).encode(),

Review Comment:
   I wonder if this change is necessary. Do we want to encourage airflow users to send bytes (which is consistent with boto3) or leave it in the current way of sending str?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org