You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2018/11/29 01:31:47 UTC
[Impala-ASF-CR] Regenerate missing configuration files in run-all.sh
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12006
Change subject: Regenerate missing configuration files in run-all.sh
......................................................................
Regenerate missing configuration files in run-all.sh
When bin/clean.sh runs, it removes some configuration
files in fe/src/test/resources that are required for
the minicluster to function.
This changes testdata/bin/run-all.sh to detect when
these configurations are missing and regenerate them.
It detects issues due to running clean.sh, which is
the most common case. It is not intended to fix
anything else.
Change-Id: I9f5955574d304b343e904851cfb9081648e350f8
---
M testdata/bin/run-all.sh
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/12006/1
--
To view, visit http://gerrit.cloudera.org:8080/12006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f5955574d304b343e904851cfb9081648e350f8
Gerrit-Change-Number: 12006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Regenerate missing configuration files in run-all.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12006 )
Change subject: Regenerate missing configuration files in run-all.sh
......................................................................
Regenerate missing configuration files in run-all.sh
When bin/clean.sh runs, it removes some configuration
files in fe/src/test/resources that are required for
the minicluster to function.
This changes testdata/bin/run-all.sh to detect when
these configurations are missing and regenerate them.
It detects issues due to running clean.sh, which is
the most common case. It is not intended to fix
anything else.
Change-Id: I9f5955574d304b343e904851cfb9081648e350f8
Reviewed-on: http://gerrit.cloudera.org:8080/12006
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/run-all.sh
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Philip Zeyliger: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f5955574d304b343e904851cfb9081648e350f8
Gerrit-Change-Number: 12006
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] Regenerate missing configuration files in run-all.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12006 )
Change subject: Regenerate missing configuration files in run-all.sh
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f5955574d304b343e904851cfb9081648e350f8
Gerrit-Change-Number: 12006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 22:08:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Regenerate missing configuration files in run-all.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12006 )
Change subject: Regenerate missing configuration files in run-all.sh
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1464/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f5955574d304b343e904851cfb9081648e350f8
Gerrit-Change-Number: 12006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 02:12:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Regenerate missing configuration files in run-all.sh
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12006 )
Change subject: Regenerate missing configuration files in run-all.sh
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f5955574d304b343e904851cfb9081648e350f8
Gerrit-Change-Number: 12006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 18:13:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Regenerate missing configuration files in run-all.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12006 )
Change subject: Regenerate missing configuration files in run-all.sh
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3504/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f5955574d304b343e904851cfb9081648e350f8
Gerrit-Change-Number: 12006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Nov 2018 18:14:32 +0000
Gerrit-HasComments: No