[GitHub] [hive] ayushtkn commented on a change in pull request #3052: HIVE-25981: Avoid checking for archived parts in analyze table.

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #3052:
URL: https://github.com/apache/hive/pull/3052#discussion_r815824924



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -13130,8 +13131,7 @@ public void validate() throws SemanticException {
 
           LOG.debug("validated " + usedp.getName());
           LOG.debug(usedp.getTable().getTableName());
-          WriteEntity.WriteType writeType = writeEntity.getWriteType();
-          if (writeType != WriteType.UPDATE && writeType != WriteType.DELETE) {
+          if (!transactionalInQuery && conf.getBoolVar(HIVEARCHIVEENABLED)) {

Review comment:
       @pvary 
   the variable is set based on that only above:
   ```
             if (AcidUtils.isTransactionalTable(tbl)) {
               transactionalInQuery = true;
   ```
   At L13124, rather than re-doing AcidUtils.isTransactionalTable(tbl), making use of the variable
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org