You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/08 15:27:33 UTC
[PR] docs(footer): render social icons as uniform white [superset]
rusackas opened a new pull request, #40854:
URL: https://github.com/apache/superset/pull/40854
### SUMMARY
Follow-up to #38108, which added social media badges to the website footer.
The badges use each brand's **native fill** — Slack `#4A154B` (dark aubergine),
X `#484848` (near-black), LinkedIn/Bluesky blue, Reddit orange. Against the dark
footer background (`#173036`), **Slack is effectively invisible and X is very
low-contrast**:
| icon | fill | on `#173036` footer |
|---|---|---|
| slack | `#4A154B` | ❌ nearly invisible |
| x | `#484848` | ⚠️ low contrast |
| linkedin / bluesky / reddit | blue / blue / orange | ok |
All five are single-path SVG glyphs whose interior details (the LinkedIn "in",
the Slack gaps, the Reddit face) are **transparent cut-outs**, so a one-line
CSS filter renders them as clean, uniform **white** logos that stay legible —
the cut-outs simply show the dark footer through them. This avoids shipping
five separate recolored white SVGs and keeps the brand-colored source assets
intact for any other use.
```css
.footer__social-links img {
...
filter: brightness(0) invert(1);
}
```
### BEFORE/AFTER
Before: Slack mark blends into the footer (barely visible). After: all five
icons render as consistent white silhouettes.
### TESTING INSTRUCTIONS
Build the docs (`cd docs && yarn build && yarn serve`) and check the footer —
all five social icons render white and legible on the dark background.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(footer): render social icons as uniform white [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40854:
URL: https://github.com/apache/superset/pull/40854#issuecomment-4650567280
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(footer): render social icons as uniform white [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #40854:
URL: https://github.com/apache/superset/pull/40854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(footer): render social icons as uniform white [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40854:
URL: https://github.com/apache/superset/pull/40854#issuecomment-4650788039
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | f916a74301e974890554890f10a6026d6eb87961 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a26df687c2eed000885cc49 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-40854--superset-docs-preview.netlify.app](https://deploy-preview-40854--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5SaLM-kHPsN0VhWpFhYjo73mbw7yQspypwgrQwZ7dhaGZBEvvRSpnVQSjO1REuYq6Q6zcJnE65NmoXeMGQ97YGQdm0lpbOyGOC3w_) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-40854--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org