You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/06/28 18:41:43 UTC
[GitHub] [cassandra] frankgh opened a new pull request, #1705: CASSANDRA-17695: Fix AbstractCell#toString for tombstoned multicell CollectionTypes
frankgh opened a new pull request, #1705:
URL: https://github.com/apache/cassandra/pull/1705
Calling `AbstractCell#toString` on a tombstoned multi-cell `CollectionType` for the `date`, `duration`,
`smallint`, `time`, and `tinyint` types produces a `MarshalException`. The root cause of the issue
occurs when `AbstractCell#toString` in turns calls `AbstractType#getString(V value, ValueAccessor<V> acccesor)`.
The `TypeSerializer` performs validation of the value. However, because this value is tombstoned
the size of the value is 0 which doesn't match the type value. The failed check throws a `MarshalException`.
In this commit, we check whether the Cell is tombstoned and add the "<tombstone>" string to the
output of the `AbstractCell#toString` method for tombstoned cells.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] frankgh commented on pull request #1705: CASSANDRA-17695: Fix AbstractCell#toString for tombstoned multicell CollectionTypes
Posted by GitBox <gi...@apache.org>.
frankgh commented on PR #1705:
URL: https://github.com/apache/cassandra/pull/1705#issuecomment-1171166616
Merged via https://github.com/apache/cassandra/commit/a9725b681b948f2122f3d48b96a5c4e7403d2c39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] frankgh closed pull request #1705: CASSANDRA-17695: Fix AbstractCell#toString for tombstoned multicell CollectionTypes
Posted by GitBox <gi...@apache.org>.
frankgh closed pull request #1705: CASSANDRA-17695: Fix AbstractCell#toString for tombstoned multicell CollectionTypes
URL: https://github.com/apache/cassandra/pull/1705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org