You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/10 23:47:37 UTC

[GitHub] [airflow] potiuk commented on pull request #28773: pre-commit check for xfail in unit tests

potiuk commented on PR #28773:
URL: https://github.com/apache/airflow/pull/28773#issuecomment-1378044577

   > This is a -0.99 from me. XFail exists for a reason, we can discourage it's use without needing to remove it.
   
   Yep. I think there are reasons why you might want to have xfail. Some of the  other fixes xfails in #23539  were simply mis-used - their reason was  "the tests were flaky" but using xfail for the reason of "we know it should fail and we can fix it later" is quite ok. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org