You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Raul Gutierrez Segales (JIRA)" <ji...@apache.org> on 2013/12/04 01:31:35 UTC

[jira] [Created] (ZOOKEEPER-1828) Audit src/c/src/zookeeper.c for missing error checking & early returns

Raul Gutierrez Segales created ZOOKEEPER-1828:
-------------------------------------------------

             Summary: Audit src/c/src/zookeeper.c for missing error checking & early returns
                 Key: ZOOKEEPER-1828
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1828
             Project: ZooKeeper
          Issue Type: Bug
          Components: c client
            Reporter: Raul Gutierrez Segales


After discussing the patch for ZOOKEEPER-1632 we came to realize that many methods in the c client don't honor the internal error checking that they do (i.e.: they don't return early on error). This is bad because you might return with an error but your call (in case of the async ones) might still have been called.

So at that point it's unclear how the caller should deal with resource deallocation.  



--
This message was sent by Atlassian JIRA
(v6.1#6144)