You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/02/11 00:03:44 UTC
[Impala-ASF-CR] IMPALA-11914: Fix broken verbose explain on MT DOP > 0
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19491
Change subject: IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
......................................................................
IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
When running with MT_DOP>0, EXPLAIN_LEVEL=VERBOSE will produce broken
explain string on fragment consuming input from join build fragment. It
will continue printing the explain plan for that child frament, the join
build fragment, rather than skipping it. This patch fix the issue by
skipping such children fragment.
Testing:
- Add PlannerTests.testExplainVerboseMtDop
Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
---
M fe/src/main/java/org/apache/impala/planner/PlanNode.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/explain-verbose-mt_dop.test
3 files changed, 2,464 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/19491/1
--
To view, visit http://gerrit.cloudera.org:8080/19491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
Gerrit-Change-Number: 19491
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11914: Fix broken verbose explain on MT DOP > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19491 )
Change subject: IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9046/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
Gerrit-Change-Number: 19491
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Feb 2023 00:18:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11914: Fix broken verbose explain on MT DOP > 0
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19491
to look at the new patch set (#2).
Change subject: IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
......................................................................
IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
When running with MT_DOP>0, EXPLAIN_LEVEL=VERBOSE will produce broken
explain string on fragment consuming input from join build fragment. It
will continue printing the explain plan for that child fragment, the
join build fragment, rather than skipping it. This patch fix the issue
by skipping such children fragment.
Testing:
- Add PlannerTests.testExplainVerboseMtDop
Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
---
M fe/src/main/java/org/apache/impala/planner/PlanNode.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/explain-verbose-mt_dop.test
3 files changed, 2,464 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/19491/2
--
To view, visit http://gerrit.cloudera.org:8080/19491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
Gerrit-Change-Number: 19491
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11914: Fix broken verbose explain on MT DOP > 0
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19491 )
Change subject: IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
......................................................................
Patch Set 3:
Thank you for your review, Wenzhe!
--
To view, visit http://gerrit.cloudera.org:8080/19491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
Gerrit-Change-Number: 19491
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Feb 2023 05:27:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11914: Fix broken verbose explain on MT DOP > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19491 )
Change subject: IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
Gerrit-Change-Number: 19491
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Feb 2023 05:26:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11914: Fix broken verbose explain on MT DOP > 0
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19491 )
Change subject: IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
Gerrit-Change-Number: 19491
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Feb 2023 23:50:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11914: Fix broken verbose explain on MT DOP > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19491 )
Change subject: IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/12354/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/19491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
Gerrit-Change-Number: 19491
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 11 Feb 2023 00:06:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11914: Fix broken verbose explain on MT DOP > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19491 )
Change subject: IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
......................................................................
IMPALA-11914: Fix broken verbose explain on MT_DOP > 0
When running with MT_DOP>0, EXPLAIN_LEVEL=VERBOSE will produce broken
explain string on fragment consuming input from join build fragment. It
will continue printing the explain plan for that child fragment, the
join build fragment, rather than skipping it. This patch fix the issue
by skipping such children fragment.
Testing:
- Add PlannerTests.testExplainVerboseMtDop
Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
Reviewed-on: http://gerrit.cloudera.org:8080/19491
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/PlanNode.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/explain-verbose-mt_dop.test
3 files changed, 2,464 insertions(+), 0 deletions(-)
Approvals:
Wenzhe Zhou: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad082074933204daaba0c675abb34c144e12c3f7
Gerrit-Change-Number: 19491
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>