You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "Will-Lo (via GitHub)" <gi...@apache.org> on 2023/02/28 00:10:14 UTC
[GitHub] [gobblin] Will-Lo opened a new pull request, #3650: [GOBBLIN-1791] Prevent the adding of flowspec compilation errors to the scheduler's …
Will-Lo opened a new pull request, #3650:
URL: https://github.com/apache/gobblin/pull/3650
…added specs
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1791
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
When a FlowSpec is compiled through the MultihopFlowCompiler, an error is added for every possible edge where there is at least one property mismatch. The cumulation of these errors for each edge means that from a size perspective there are a lot of strings stored redundantly in the flowspec.
This PR attempts to reduce the size of the FlowSpec, which is stored within the GobblinServiceJobScheduler, by clearing all of the errors from a flowspec if a flow is successfully compiled. Compilation failures are defined when the returned Dag is null
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Unit tests
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3650: [GOBBLIN-1791] Prevent the adding of flowspec compilation errors to the scheduler's …
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3650:
URL: https://github.com/apache/gobblin/pull/3650#issuecomment-1447333521
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3650](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94ea4cd) into [master](https://codecov.io/gh/apache/gobblin/commit/af2a9c196d74b96d51dd8ee57b87cba0baceb9a5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af2a9c1) will **decrease** coverage by `5.25%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3650 +/- ##
============================================
- Coverage 49.04% 43.80% -5.25%
+ Complexity 9240 2063 -7177
============================================
Files 1752 409 -1343
Lines 68124 17647 -50477
Branches 7769 2152 -5617
============================================
- Hits 33412 7730 -25682
+ Misses 31605 9060 -22545
+ Partials 3107 857 -2250
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/gobblin/runtime/api/FlowSpec.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0Zsb3dTcGVjLmphdmE=) | | |
| [...lin/service/modules/flow/MultiHopFlowCompiler.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93L011bHRpSG9wRmxvd0NvbXBpbGVyLmphdmE=) | | |
| [...in/service/modules/orchestration/Orchestrator.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL09yY2hlc3RyYXRvci5qYXZh) | | |
| [...gobblin/service/modules/spec/JobExecutionPlan.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zcGVjL0pvYkV4ZWN1dGlvblBsYW4uamF2YQ==) | | |
| [...gobblin/runtime/locks/FileBasedJobLockFactory.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvRmlsZUJhc2VkSm9iTG9ja0ZhY3RvcnkuamF2YQ==) | | |
| [...in/metrics/reporter/util/AvroBinarySerializer.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci91dGlsL0F2cm9CaW5hcnlTZXJpYWxpemVyLmphdmE=) | | |
| [...org/apache/gobblin/runtime/api/FsSpecProducer.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0ZzU3BlY1Byb2R1Y2VyLmphdmE=) | | |
| [...apache/gobblin/compression/CompressionFactory.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29tcHJlc3Npb24vQ29tcHJlc3Npb25GYWN0b3J5LmphdmE=) | | |
| [...in/source/extractor/WatermarkSerializerHelper.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc291cmNlL2V4dHJhY3Rvci9XYXRlcm1hcmtTZXJpYWxpemVySGVscGVyLmphdmE=) | | |
| [...a/org/apache/gobblin/util/RecordCountProvider.java](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdXRpbC9SZWNvcmRDb3VudFByb3ZpZGVyLmphdmE=) | | |
| ... and [1335 more](https://codecov.io/gh/apache/gobblin/pull/3650?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3650: [GOBBLIN-1791] Prevent the adding of flowspec compilation errors to the scheduler's …
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3650:
URL: https://github.com/apache/gobblin/pull/3650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org