You are viewing a plain text version of this content. The canonical link for it is here.

Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2008/12/16 16:12:44 UTC

[jira] Commented: (SOLR-917) RequestHandlers#handlers is a synchronizedMap()

    [ https://issues.apache.org/jira/browse/SOLR-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657011#action_12657011 ] 

Yonik Seeley commented on SOLR-917:
-----------------------------------

Remember to test patches - this causes everything to fail since ConcurrentHashMap can't take null keys.

> RequestHandlers#handlers is a synchronizedMap()
> -----------------------------------------------
>
>                 Key: SOLR-917
>                 URL: https://issues.apache.org/jira/browse/SOLR-917
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-917.patch
>
>
> {code}
>   private final Map<String, SolrRequestHandler> handlers = Collections.synchronizedMap(
>       new HashMap<String,SolrRequestHandler>() );
> {code}
> this map is queried for every request and it can easily be made ConcurrentHashMap

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.