You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/09 07:57:17 UTC

[GitHub] [kafka] cadonna commented on pull request #10846: KAFKA-12914: StreamSourceNode should return `null` topic name for pattern subscription

cadonna commented on pull request #10846:
URL: https://github.com/apache/kafka/pull/10846#issuecomment-857476064


   `Optional` sounds good but it would substantially increase the size of this fix which is actually not required.
   
   On the other hand, I am not sure if we do not have other related NPE lurking in the code that should be found by changing to `Optional`. For example, I could not find a null check for https://github.com/apache/kafka/blob/45d7440c1577b838d4584d3860e5c4d691446f3f/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNode.java#L86 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org