You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/03/30 02:53:34 UTC

[GitHub] [netbeans] mbien opened a new pull request, #5744: make maven project properties window aware of the javac release option

mbien opened a new pull request, #5744:
URL: https://github.com/apache/netbeans/pull/5744

   the properties window will now update the release option if it can be found and use source/target otherwise. 
   
   it will also make sure that both are not used at the same time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a diff in pull request #5744: make maven project properties window aware of the javac release option

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5744:
URL: https://github.com/apache/netbeans/pull/5744#discussion_r1152676797


##########
java/maven/src/org/netbeans/modules/maven/customizer/SourcesPanel.java:
##########
@@ -76,20 +76,36 @@ public class SourcesPanel extends JPanel implements HelpCtx.Provider {
         @Override
         public void performOperation(POMModel model) {
             String s = PluginPropertyUtils.getPluginProperty(handle.getProject(), Constants.GROUP_APACHE_PLUGINS, Constants.PLUGIN_COMPILER, "source", null, null);
-            String t = PluginPropertyUtils.getPluginProperty(handle.getProject(), Constants.GROUP_APACHE_PLUGINS, Constants.PLUGIN_COMPILER, "source", null, null);

Review Comment:
   this was likely a minor bug since `source` was used twice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien merged pull request #5744: make maven project properties window aware of the javac release option

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5744:
URL: https://github.com/apache/netbeans/pull/5744


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #5744: make maven project properties window aware of the javac release option

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5744:
URL: https://github.com/apache/netbeans/pull/5744#issuecomment-1491148785

   thanks for review. going to force push to resolve the javadoc conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a diff in pull request #5744: make maven project properties window aware of the javac release option

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5744:
URL: https://github.com/apache/netbeans/pull/5744#discussion_r1152676797


##########
java/maven/src/org/netbeans/modules/maven/customizer/SourcesPanel.java:
##########
@@ -76,20 +76,36 @@ public class SourcesPanel extends JPanel implements HelpCtx.Provider {
         @Override
         public void performOperation(POMModel model) {
             String s = PluginPropertyUtils.getPluginProperty(handle.getProject(), Constants.GROUP_APACHE_PLUGINS, Constants.PLUGIN_COMPILER, "source", null, null);
-            String t = PluginPropertyUtils.getPluginProperty(handle.getProject(), Constants.GROUP_APACHE_PLUGINS, Constants.PLUGIN_COMPILER, "source", null, null);

Review Comment:
   this was likely a minor bug since source was used twice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists