You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/13 22:01:24 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #7498: Reduce db queries in /queries/ endpoint

graceguo-supercat opened a new pull request #7498: Reduce db queries in /queries/ endpoint
URL: https://github.com/apache/incubator-superset/pull/7498
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   In #4833, we tried to introduce a feature that setting old async query status to be timed_out, when the query status stuck at pending or running after 6 hours. This status update will help front-end (browser) not fetching very old query status. But i found that backend actually didn't commit transaction, so the whole query/update logic seems no use.
   
   In front-end javascript, we have logic that don't poll query status after `SQLLAB_ASYNC_TIME_LIMIT_SEC` reached. I feel the additional query/update in backend every second, seems expensive and not necessary. So I propose to remove this query/update logic.
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   n/a
   
   ### TEST PLAN
   CI and watch query polling.
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @john-bodley @timifasubaa @mistercrunch @michellethomas 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org