[jira] [Comment Edited] (CASSANDRA-5149) Respect slice count even if column expire mid-request

["Aleksey Yeschenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680917#comment-13680917 ] 

Aleksey Yeschenko edited comment on CASSANDRA-5149 at 6/12/13 3:14 AM:
-----------------------------------------------------------------------

https://github.com/iamaleksey/cassandra/commits/5149

The first patch adds timestamp field to all IReadCommands and makes sure it's always set appropriately.

The second patch updates the read path to respect the request timestamp. It also normalizes the argument order for CFS.getRangeSlice() and CFS.search(). This was not necessary, but the order they were in bothered me immensely. The third patch fixes the tests broken by this rearrangement.

I'll add some unit tests after the code review.
                
      was (Author: iamaleksey):
    https://github.com/iamaleksey/cassandra/commits/5149

The first patch adds timestamp field to all IReadCommands and makes sure it's always set appropriately.

The second patch updates the read path to respect the request timestamp. It also normalizes the argument order for CFS.getRangeSlice() and CFS.search(). This was not necessary, but the order they were in bothered me immensely. The third patch fixes the tests broken by this rearrangement.
                  
> Respect slice count even if column expire mid-request
> -----------------------------------------------------
>
>                 Key: CASSANDRA-5149
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5149
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Sylvain Lebresne
>            Assignee: Aleksey Yeschenko
>             Fix For: 2.0
>
>
> This is a follow-up of CASSANDRA-5099.
> If a column expire just while a slice query is performed, it is possible for replicas to count said column as live but to have the coordinator seeing it as dead when building the final result. The effect that the query might return strictly less columns that the requested slice count even though there is some live columns matching the slice predicate but not returned in the result.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira