You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/19 22:13:52 UTC
[GitHub] [spark] zero323 opened a new pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
zero323 opened a new pull request #30094:
URL: https://github.com/apache/spark/pull/30094
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add type hints guidelines to developer docs.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Since it is a new and still somewhat evolving feature, we should provided clear guidelines for potential contributors.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-714018326
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34718/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712471618
**[Test build #130022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130022/testReport)** for PR 30094 at commit [`6928aa4`](https://github.com/apache/spark/commit/6928aa4d5076ee86a60ebb432bda729db6cd018b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712479514
**[Test build #130022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130022/testReport)** for PR 30094 at commit [`6928aa4`](https://github.com/apache/spark/commit/6928aa4d5076ee86a60ebb432bda729db6cd018b).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712471618
**[Test build #130022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130022/testReport)** for PR 30094 at commit [`6928aa4`](https://github.com/apache/spark/commit/6928aa4d5076ee86a60ebb432bda729db6cd018b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-713967509
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34718/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-713948287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-715606779
Thanks for checking this @HyukjinKwon! I think it is ready for review ‒ I've modified grammar as requested and section about validating.
As of user part, I decided against adding it for now. I have some hints, but these seem to be too localized (specific editors, common typing issues), while for most of the users, benefits will be mostly transparent. Maybe we could add a short guide for different environments (I have [this answer](https://stackoverflow.com/a/34714207) on Stack, which seems to be weirdly popular) and add some typing notes there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-715842306
Thanks @HyukjinKwon!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712479711
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-713947013
**[Test build #130109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130109/testReport)** for PR 30094 at commit [`88a04a7`](https://github.com/apache/spark/commit/88a04a7c37a8618b6d9cf91b0b6f575a412a764c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-713919685
**[Test build #130109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130109/testReport)** for PR 30094 at commit [`88a04a7`](https://github.com/apache/spark/commit/88a04a7c37a8618b6d9cf91b0b6f575a412a764c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712497589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-714018320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-714018309
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34718/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30094:
URL: https://github.com/apache/spark/pull/30094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-714018320
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30094:
URL: https://github.com/apache/spark/pull/30094#discussion_r508149218
##########
File path: python/docs/source/development/contributing.rst
##########
@@ -77,6 +77,43 @@ There are a couple of additional notes to keep in mind when contributing to code
* Be Pythonic.
* APIs are matched with Scala and Java sides in general.
* PySpark specific APIs can still be considered as long as they are Pythonic and do not conflict with other existent APIs, for example, decorator usage of UDFs.
+* If you extend or modify public API, please adjust corresponding type hints. See `Contributing and Maintaining Type Hints`_ for details.
+
+Contributing and Maintaining Type Hints
+----------------------------------------
+
+PySpark type hints are provided using stub files, placed in the same directory as the annotated module, with exception to ``# type: ignore`` in modules which don't have their own stubs (tests, examples, non-public API).
Review comment:
just a nit but maybe: `tests, examples, non-public API` -> `tests, examples and non-public API`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712479714
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130022/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-715647562
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712479711
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712524154
Looks pretty good. Let me know when you think it's ready @zero323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712497589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712497576
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34629/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guideliness to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-712487785
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34629/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-713948287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-713919685
**[Test build #130109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130109/testReport)** for PR 30094 at commit [`88a04a7`](https://github.com/apache/spark/commit/88a04a7c37a8618b6d9cf91b0b6f575a412a764c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org