[GitHub] spark pull request #10307: [SPARK-12334][SQL][PYSPARK] Support read from mul...

[holdenk <gi...@git.apache.org>]

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10307#discussion_r103530578
  
    --- Diff: python/pyspark/sql/readwriter.py ---
    @@ -388,16 +388,18 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non
             return self._df(self._jreader.csv(self._spark._sc._jvm.PythonUtils.toSeq(path)))
     
         @since(1.5)
    -    def orc(self, path):
    -        """Loads an ORC file, returning the result as a :class:`DataFrame`.
    +    def orc(self, paths):
    --- End diff --
    
    So if someones been calling orc with a named param of path this could cause them problems when they upgrade. I might be being overly cautious but it seems like we should avoid breaking that since we don't have to until the next major version change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org