You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/03/29 22:15:25 UTC

[GitHub] jai1 commented on a change in pull request #1450: Added multiple position delete in ManagedLedger

jai1 commented on a change in pull request #1450: Added multiple position delete in ManagedLedger
URL: https://github.com/apache/incubator-pulsar/pull/1450#discussion_r178195869
 
 

 ##########
 File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
 ##########
 @@ -1447,8 +1447,17 @@ public void operationFailed(ManagedLedgerException exception) {
 
     @Override
     public void delete(final Position position) throws InterruptedException, ManagedLedgerException {
-        checkNotNull(position);
 
 Review comment:
   We should have these checks in ManagedCursorImpl.java:1524 (asyncDelete)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services