You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2008/02/07 14:59:22 UTC

Re: [classlib]remove the duplicate locale data

On 7 February 2008 at 15:48, "Alexey Petrenko" <al...@gmail.com> 
wrote:
> 2008/2/6, Tony Wu <wu...@gmail.com>:
> > On 2/7/08, Alexey Petrenko <al...@gmail.com> wrote:
> > > I would suggest to mark these issues as "must be fixed before M5"
> > > since Harmony M5 should not be worse then M4.
> > Why do you think these differences are so important?
> Because these issues are regressions :)

Alexey, I don't think that is fair.  Regressions are changes that affect
things negatively and improvements are changes that affect things
positively.  Some of these may turn out to fall in the middle but many
of them will turn out to be improvements - i.e. because they are up to
date and the RI is outdated.

To me, Tony's question about why these are important is crucial.

If the issues were found with test cases, then why aren't these tests
checked in?  (If they were Tony would have had a chance to discover them
before making his changes in trunk.)

If the issues were found by application errors, then these are fair more
critical and I'm sure Tony was asking so that he might focus on these.

Personally, if these issues are application failures then I am +1 that
they "must be fixed before M5" but if they are test case regressions
then it is not so clear cut.  I'd have to weigh up the positive and
negative effects of the ICU changes.

Regards,
 Mark.



Re: [classlib]remove the duplicate locale data

Posted by Alexey Petrenko <al...@gmail.com>.
BTW, I would move this discussion to separate thread to get more
community attention and opinions.

SY, Alexey

2008/2/9, Alexey Petrenko <al...@gmail.com>:
> 2008/2/7, Mark Hindess <ma...@googlemail.com>:
> >
> > On 7 February 2008 at 15:48, "Alexey Petrenko" <al...@gmail.com>
> > wrote:
> > > 2008/2/6, Tony Wu <wu...@gmail.com>:
> > > > On 2/7/08, Alexey Petrenko <al...@gmail.com> wrote:
> > > > > I would suggest to mark these issues as "must be fixed before M5"
> > > > > since Harmony M5 should not be worse then M4.
> > > > Why do you think these differences are so important?
> > > Because these issues are regressions :)
> > Alexey, I don't think that is fair.
> Do not agree with this :)
>
> But
> > Regressions are changes that affect
> > things negatively and improvements are changes that affect things
> > positively.  Some of these may turn out to fall in the middle but many
> > of them will turn out to be improvements - i.e. because they are up to
> > date and the RI is outdated.
> I'm fully agree with this.
>
> We have applications or internal/external test suite failures. And all
> of this failures could be regressions or not. And we can not be fully
> sure until we will investigate each case.
> So if our next milestone build has new failures, does not matter on
> applications or test suites, anyone  can say that M5 is worse then M4.
> And we could not reply anything on this because we just do not know
> are these failures regressions, non-bug-differencies or even
> improvements.
>
> Thus I vote to investigate all the new discovered issues caused by
> this or any other commit and resolve them.
>
> SY, Alexey
>

Re: [classlib]remove the duplicate locale data

Posted by Tim Ellison <t....@gmail.com>.
Alexey Petrenko wrote:
> 2008/2/7, Mark Hindess <ma...@googlemail.com>:
>> On 7 February 2008 at 15:48, "Alexey Petrenko" <al...@gmail.com>
>> wrote:
>>> 2008/2/6, Tony Wu <wu...@gmail.com>:
>>>> On 2/7/08, Alexey Petrenko <al...@gmail.com> wrote:
>>>>> I would suggest to mark these issues as "must be fixed before M5"
>>>>> since Harmony M5 should not be worse then M4.
>>>> Why do you think these differences are so important?
>>> Because these issues are regressions :)
>> Alexey, I don't think that is fair.
> Do not agree with this :)
> 
> But
>> Regressions are changes that affect
>> things negatively and improvements are changes that affect things
>> positively.  Some of these may turn out to fall in the middle but many
>> of them will turn out to be improvements - i.e. because they are up to
>> date and the RI is outdated.
> I'm fully agree with this.
> 
> We have applications or internal/external test suite failures. And all
> of this failures could be regressions or not. And we can not be fully
> sure until we will investigate each case.
> So if our next milestone build has new failures, does not matter on
> applications or test suites, anyone  can say that M5 is worse then M4.
> And we could not reply anything on this because we just do not know
> are these failures regressions, non-bug-differencies or even
> improvements.
> 
> Thus I vote to investigate all the new discovered issues caused by
> this or any other commit and resolve them.

Yes, they should all be investigated so we can make a determination for M5.

Regards,
Tim

Re: [classlib]remove the duplicate locale data

Posted by Alexey Petrenko <al...@gmail.com>.
2008/2/7, Mark Hindess <ma...@googlemail.com>:
>
> On 7 February 2008 at 15:48, "Alexey Petrenko" <al...@gmail.com>
> wrote:
> > 2008/2/6, Tony Wu <wu...@gmail.com>:
> > > On 2/7/08, Alexey Petrenko <al...@gmail.com> wrote:
> > > > I would suggest to mark these issues as "must be fixed before M5"
> > > > since Harmony M5 should not be worse then M4.
> > > Why do you think these differences are so important?
> > Because these issues are regressions :)
> Alexey, I don't think that is fair.
Do not agree with this :)

But
> Regressions are changes that affect
> things negatively and improvements are changes that affect things
> positively.  Some of these may turn out to fall in the middle but many
> of them will turn out to be improvements - i.e. because they are up to
> date and the RI is outdated.
I'm fully agree with this.

We have applications or internal/external test suite failures. And all
of this failures could be regressions or not. And we can not be fully
sure until we will investigate each case.
So if our next milestone build has new failures, does not matter on
applications or test suites, anyone  can say that M5 is worse then M4.
And we could not reply anything on this because we just do not know
are these failures regressions, non-bug-differencies or even
improvements.

Thus I vote to investigate all the new discovered issues caused by
this or any other commit and resolve them.

SY, Alexey