[GitHub] [incubator-heron] nicknezis edited a comment on pull request #3754: Updated Kubernetes client library to 14.0.0

[GitBox <gi...@apache.org>]

nicknezis edited a comment on pull request #3754:
URL: https://github.com/apache/incubator-heron/pull/3754#issuecomment-1005093921


   > This is good work. I believe it is vital that all of our dependencies live as close to `HEAD` of their respective repos as possible. Please ping when it is ready for review.
   
   Ok, rebased off of the new `master` branch. Updated the pinned dependencies. I think this is ready for testing. 
   
   FYI, the unit tests you added already helped catch a build issue with this update. We had `org.yaml:snakeyaml` explicitly defined. The older version didn't work. I updated to the latest `1.30`. But I also tried removing the explicit dependency and it resolved to `1.29`. I'm leaning towards removing the entry and letting the Maven dependency info drive which version is selected. This might be better for maintaining going forward. If you agree, I'll remove the mention of `snakeyml` in the dependencies list. 
   
   I believe there are other dependencies listed that no longer need to be listed. They were in the list before we had actual transitive dependency resolution logic helping us.
   
   _Edit: I talked myself into it. I removed the direct mention of snakeyml dependency._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org