You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2016/02/04 03:17:58 UTC

[GitHub] activemq-artemis pull request: ARTEMIS-385 fixing race

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/369

    ARTEMIS-385 fixing race

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-385

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/369.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #369
    
----
commit ba7e11a54c6b487b2d2fc5a970fe1521bcf69906
Author: Clebert Suconic <cl...@apache.org>
Date:   2016-02-04T02:14:26Z

    ARTEMIS-385 On a possible race the Topology final notification may get lost when using many connection factories
    
    https://issues.apache.org/jira/browse/ARTEMIS-385
    
    This fix will make sure we only wait for the topologies that are arriving from the current connection over the createFactory method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-385 fixing race

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/369


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-385 fixing race

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/369#issuecomment-179587849
  
    @clebertsuconic, I certainly think it's possible.  However, I haven't dug into that issue much as I've been working on other tasks so I can't say for sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-385 fixing race

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/369#issuecomment-179582606
  
    @jbertram  this could be related to the issue you were hitting on backup?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-385 fixing race

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/369#issuecomment-179829081
  
    The failure on jenkins is non related. But there's a failure on a test and I'm investigating this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-385 fixing race

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/369#issuecomment-179598163
  
    @jbertram sure.. was just mentioning as I bumped into this by accident.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-385 fixing race

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/369#issuecomment-179873433
  
    test fixed! ready to merge again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---