You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jonathan Eagles (JIRA)" <ji...@apache.org> on 2017/03/24 18:00:45 UTC

[jira] [Commented] (HADOOP-14233) Delay construction of PreCondition.check failure message in Configuration#set

    [ https://issues.apache.org/jira/browse/HADOOP-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940831#comment-15940831 ] 

Jonathan Eagles commented on HADOOP-14233:
------------------------------------------

My local benchmarking shows a roughly %15 performance gain for Configuration.set after applying this patch.

> Delay construction of PreCondition.check failure message in Configuration#set
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-14233
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14233
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: HADOOP-14233.1.patch
>
>
> The String in the precondition check is constructed prior to failure detection. Since the normal case is no error, we can gain performance by delaying the construction of the string until the failure is detected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org