[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

[GitBox <gi...@apache.org>]

hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r248513031
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
 ##########
 @@ -215,6 +217,19 @@ class RelTimeIndicatorConverter(rexBuilder: RexBuilder) extends RelShuttle {
     materializerUtils.projectAndMaterializeFields(rewrittenTemporalJoin, indicesToMaterialize)
   }
 
+  def visit(upsertToRetraction: LogicalUpsertToRetraction): RelNode = {
 
 Review comment:
   Good catch!
   > First you didn't recursively call the RelTimeIndicatorConverter on the upsertToRetraction input
   The `LogicalUpsertToRetraction` is right after the source. There is no case we need to materialize time indicators in source. Currently, visit() return scan directly in `RelTimeIndicatorConverter`. But I think you are right. It is better to visit input for `LogicalUpsertToRetraction`. However, it seems impossible for us to add a test for this.
   
   > Secondly, we should solve this in some more generic way.
   Agree. I suggest to do it in another pr. It is self contained. This pr is a bit big. I would rather not to add new feature in it. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services