You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/04/06 02:30:28 UTC

[GitHub] [iceberg] xloya commented on a diff in pull request #4427: [Spark][Core]: Release memory when rewriting RewriteFileGroup finished

xloya commented on code in PR #4427:
URL: https://github.com/apache/iceberg/pull/4427#discussion_r843407010


##########
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java:
##########
@@ -198,9 +199,9 @@ public void offer(RewriteFileGroup group) {
     }
 
     /**
-     * Returns all File groups which have been committed
+     * Returns all file groups results which have been committed
      */
-    public List<RewriteFileGroup> results() {
+    public List<RewriteDataFiles.FileGroupRewriteResult> results() {

Review Comment:
   Of course, I think the `FileGroupRewriteResult` interface can be taken out separately to solve this problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org