You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/28 06:52:37 UTC

[GitHub] [lucene] jpountz commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

jpountz commented on a change in pull request #324:
URL: https://github.com/apache/lucene/pull/324#discussion_r717275045



##########
File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java
##########
@@ -292,7 +293,11 @@ public long cost() {
 
         @Override
         public int advance(int target) throws IOException {
-          return docID = competitiveIterator.advance(target);
+          if (target <= startDocID) {

Review comment:
       Can you leave a comment about why we need to do this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org