You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/06/22 10:21:45 UTC
[GitHub] [rocketmq] yglovewms opened a new pull request #3029: delete:删除package org.apache.rocketmq.client.impl.consumer.ConsumeMess…
yglovewms opened a new pull request #3029:
URL: https://github.com/apache/rocketmq/pull/3029
…ageConcurrentlyService 中incCorePoolSize与decCorePoolSize的无用注释代码，令既然这两个类暂时无用为什么要加上
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yglovewms commented on pull request #3029: delete:删除package org.apache.rocketmq.client.impl.consumer.ConsumeMess…
Posted by GitBox <gi...@apache.org>.
yglovewms commented on pull request #3029:
URL: https://github.com/apache/rocketmq/pull/3029#issuecomment-865906384
请问一下咋合并呀，对rocketmq这块兴趣蛮大的，想多提几次pr当contributer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3029: delete:删除package org.apache.rocketmq.client.impl.consumer.ConsumeMess…
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3029:
URL: https://github.com/apache/rocketmq/pull/3029#issuecomment-865889038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yglovewms removed a comment on pull request #3029: delete:删除package org.apache.rocketmq.client.impl.consumer.ConsumeMess…
Posted by GitBox <gi...@apache.org>.
yglovewms removed a comment on pull request #3029:
URL: https://github.com/apache/rocketmq/pull/3029#issuecomment-865906384
请问一下咋合并呀，对rocketmq这块兴趣蛮大的，想多提几次pr当contributer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed pull request #3029: delete:删除package org.apache.rocketmq.client.impl.consumer.ConsumeMess…
Posted by GitBox <gi...@apache.org>.
duhenglucky closed pull request #3029:
URL: https://github.com/apache/rocketmq/pull/3029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org