You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by mkby <gi...@git.apache.org> on 2017/06/28 06:28:07 UTC
[GitHub] incubator-trafodion pull request #1152: [TRAFODION-2658] pyinstaller - suppo...
GitHub user mkby opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1152
[TRAFODION-2658] pyinstaller - support elastic adding nodes
init version of pyinstaller elastic feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkby/incubator-trafodion pyinstall_elastic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1152
----
commit d07a3042595b9af4b72b7caea9782f969fa54b25
Author: Eason <hf...@gmail.com>
Date: 2017-06-21T13:10:04Z
[TRAFODION-2658] pyinstaller - support elastic adding nodes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1152: [TRAFODION-2658] pyinstaller - suppo...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1152#discussion_r125368329
--- Diff: core/sqf/sql/scripts/sqregen ---
@@ -41,8 +41,15 @@ function Usage {
function RegenConfig {
echo "Regenerating Trafodion configuration: $SQCONFIG_FILE"
+ cd $TRAF_HOME/sql/scripts
./regensq.pl $SQCONFIG_FILE
- exit $?;
+ if [ $? != 0 ]; then
+ echo "Failed to run regensq.pl."
--- End diff --
The error message is incorrect. We did run regensq.pl. The problem is that regensq.pl failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1152: [TRAFODION-2658] pyinstaller - suppo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1152: [TRAFODION-2658] pyinstaller - suppo...
Posted by mkby <gi...@git.apache.org>.
Github user mkby commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1152#discussion_r125371556
--- Diff: core/sqf/sql/scripts/sqregen ---
@@ -41,8 +41,15 @@ function Usage {
function RegenConfig {
echo "Regenerating Trafodion configuration: $SQCONFIG_FILE"
+ cd $TRAF_HOME/sql/scripts
./regensq.pl $SQCONFIG_FILE
- exit $?;
+ if [ $? != 0 ]; then
+ echo "Failed to run regensq.pl."
--- End diff --
sounds good, I will change the message, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1152: [TRAFODION-2658] pyinstaller - suppo...
Posted by mkby <gi...@git.apache.org>.
Github user mkby commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1152#discussion_r125371611
--- Diff: core/sqf/sql/scripts/sqregen ---
@@ -41,8 +41,15 @@ function Usage {
function RegenConfig {
echo "Regenerating Trafodion configuration: $SQCONFIG_FILE"
+ cd $TRAF_HOME/sql/scripts
./regensq.pl $SQCONFIG_FILE
- exit $?;
+ if [ $? != 0 ]; then
+ echo "Failed to run regensq.pl."
+ exit $?
+ fi
+ echo "Copying Trafodion configuration file $SQCONFIG_FILE to all nodes"
+ pdcp `trafconf -wname` $SQCONFIG_FILE $TRAF_HOME/sql/scripts/
--- End diff --
I think pdcp itself will show the error message if fails
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1152: [TRAFODION-2658] pyinstaller - suppo...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1152#discussion_r125368361
--- Diff: core/sqf/sql/scripts/sqregen ---
@@ -41,8 +41,15 @@ function Usage {
function RegenConfig {
echo "Regenerating Trafodion configuration: $SQCONFIG_FILE"
+ cd $TRAF_HOME/sql/scripts
./regensq.pl $SQCONFIG_FILE
- exit $?;
+ if [ $? != 0 ]; then
+ echo "Failed to run regensq.pl."
+ exit $?
+ fi
+ echo "Copying Trafodion configuration file $SQCONFIG_FILE to all nodes"
+ pdcp `trafconf -wname` $SQCONFIG_FILE $TRAF_HOME/sql/scripts/
--- End diff --
Should there be an error message if pdcp fails?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---