You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by jacobtolar <gi...@git.apache.org> on 2018/10/19 19:17:48 UTC

[GitHub] storm pull request #2888: [STORM-3263] Fix sorting by owner resources in the...

GitHub user jacobtolar opened a pull request:

    https://github.com/apache/storm/pull/2888

    [STORM-3263] Fix sorting by owner resources in the UI

    See the jira for before/after picture. I tested with the following in the chrome console: 
    
    ```
    myData = $('#owner-summary-table').DataTable().data()
    $('#owner-summary-table').DataTable().destroy()
    
    $.extend( $.fn.dataTableExt.oSort, {
      "resource-num-pre": function(raw) {
        if (raw == 'N/A') {
          return Number.NEGATIVE_INFINITY;
        } else {
          return $.fn.dataTableExt.oSort['num-pre'](raw);
        }
      },
      "resource-num-asc": $.fn.dataTableExt.oSort['num-asc'],
      "resource-num-desc": $.fn.dataTableExt.oSort['num-desc']
    });
    
    // paste in new definition of makeOwnerSummaryTable as myOwnerTable...
    
    myOwnerTable('#owner-summary-table', '#owner-summary')
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jacobtolar/storm STORM-3263

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2888
    
----
commit 6b0373703ab89648943f52ec87c43531e2defc84
Author: Jacob Tolar <jt...@...>
Date:   2018-10-19T19:14:32Z

    [STORM-3263] Fix sorting by owner resources in the UI

----


---

[GitHub] storm pull request #2888: [STORM-3263] Fix sorting by owner resources in the...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2888


---