You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/07/12 08:35:00 UTC

[jira] [Commented] (DISPATCH-2346) Change PN_WEAKREF usage to PN_VOID usage to continue compiling with Proton

    [ https://issues.apache.org/jira/browse/DISPATCH-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565367#comment-17565367 ] 

ASF subversion and git services commented on DISPATCH-2346:
-----------------------------------------------------------

Commit db24732de7b0143428d2359c4ad8af6e842a57e4 in qpid-dispatch's branch refs/heads/dependabot/github_actions/actions/upload-artifact-3 from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=db24732d ]

DISPATCH-2346: Change PN_WEAKREF usage to PN_VOID

PN_VOID is what should have been used initially as the context type in
this record is not a proton PN_OBJECT class type anyway. Moreover
PN_WEAKREF will soon not be exported as it probably can't be used
correctly outside Proton's own libraries.


> Change PN_WEAKREF usage to PN_VOID usage to continue compiling with Proton
> --------------------------------------------------------------------------
>
>                 Key: DISPATCH-2346
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2346
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>            Priority: Major
>             Fix For: 1.20.0, 2.0.0
>
>
> Qpid Proton is changing (removing) some of the exported symbols that are really internal to Proton and should not be used (or even cannot be correctly used) outside Proton's own libraries.
> The PN_WEAKREF class is one such example - it seems to be the wrong class for the purpose it is being used for in dispatch. PN_VOID is the correct class in this usage and PN_WEAKREF will stop being exported soon. So to keep dispatch compiling PN_WEAKREF has been changed to PN_VOID.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org