You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/11 10:51:06 UTC

[GitHub] [flink] zhijiangW commented on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure

zhijiangW commented on issue #9879: [FLINK-14300][runtime, test] Add test making sure that RecordWriter is properly closed in case of early StreamTask failure
URL: https://github.com/apache/flink/pull/9879#issuecomment-541015897
 
 
   Thanks for the updates @pnowojski .
   
   > But it is positive to avoid adding extra flag field to indicate the closed state in RecordWriter.
   
   I also felt the current way is positive than adding extra stateful `isClosed` field.
   
   LGTM and wait for the travis pass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services